Date: Wed, 11 Apr 2012 08:08:42 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Ed Schouten <ed@80386.nl> Cc: "O. Hartmann" <ohartman@mail.zedat.fu-berlin.de>, Current FreeBSD <freebsd-current@freebsd.org> Subject: Re: Changes to sbin/init/init.c (r233944) makes x11/xdm impossible to start from /etc/ttys Message-ID: <20120411050842.GE2358@deviant.kiev.zoral.com.ua> In-Reply-To: <20120410203645.GI62756@hoeg.nl> References: <4F83FF50.1010404@mail.zedat.fu-berlin.de> <20120410203645.GI62756@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--pCkiZZNKSjytm5Qt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 10, 2012 at 10:36:45PM +0200, Ed Schouten wrote: > Hi Oliver, >=20 > * O. Hartmann <ohartman@mail.zedat.fu-berlin.de>, 20120410 11:37: > > Reverting init.c back to its previous state seems to make the error go = away. >=20 > Sorry about that. I added the O_NONBLOCK to prevent init(8) from > possibly getting stuck if the TTY used by /dev/console were to misbehave > by not setting CLOCAL. >=20 > It seems we can't do this reliably at all, so I guess I'd better just > revert the code like so: >=20 > http://80386.nl/pub/init.txt >=20 > I'll commit the patch to SVN after I have discussed it wtih kib@. Thanks > for reporting! Ok, lets discuss. I do not understand why this patch makes any change at al= l. Esp. for xdm that is supposedly run on some vty and not on console. --pCkiZZNKSjytm5Qt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk+FEdoACgkQC3+MBN1Mb4ggJwCcCU2GgpdxCIASiRHsGbp1ESOV O/YAoKn5rvN3e0Nx1gZyQ7aQCLs5tuCa =qv49 -----END PGP SIGNATURE----- --pCkiZZNKSjytm5Qt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120411050842.GE2358>