From owner-cvs-src@FreeBSD.ORG Thu Oct 25 19:09:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 04F1116A469; Thu, 25 Oct 2007 19:09:44 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [210.51.165.229]) by mx1.freebsd.org (Postfix) with ESMTP id 90E6013C494; Thu, 25 Oct 2007 19:09:43 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from localhost (tarsier.geekcn.org [210.51.165.229]) by tarsier.geekcn.org (Postfix) with ESMTP id B1DB9EC2ED1; Fri, 26 Oct 2007 03:09:42 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([210.51.165.229]) by localhost (mail.geekcn.org [210.51.165.229]) (amavisd-new, port 10024) with ESMTP id wuvkKnF7LSsb; Fri, 26 Oct 2007 03:09:36 +0800 (CST) Received: from LI-Xins-MacBook.local (71.5.7.139.ptr.us.xo.net [71.5.7.139]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTP id 85E2DEB27B1; Fri, 26 Oct 2007 03:09:34 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:subject:references:in-reply-to:x-enigmail-version:openpgp:content-type; b=Z842nOhBNmwpeP2Pw+zI8sITY+jku/8kZLCSiO1AsRdJPeGapoN4sqrLlGaQG4Wbd 1HC128BPuh+nlolVljEpQ== Message-ID: <4720E9E1.7000900@delphij.net> Date: Thu, 25 Oct 2007 12:09:21 -0700 From: LI Xin Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: Andrey Chernov , d@delphij.net, Scott Long , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru> <4720C7D6.9090004@delphij.net> <20071025190019.GA16187@nagual.pp.ru> In-Reply-To: <20071025190019.GA16187@nagual.pp.ru> X-Enigmail-Version: 0.95.4 OpenPGP: url=http://www.delphij.net/delphij.asc Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig9372C5B26114F9F41A4DDFE6" Cc: Subject: Re: cvs commit: src/lib/libc/locale utf8.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2007 19:09:44 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9372C5B26114F9F41A4DDFE6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Andrey Chernov wrote: > On Thu, Oct 25, 2007 at 09:44:06AM -0700, LI Xin wrote: >> Andrey Chernov wrote: >>> On Thu, Oct 25, 2007 at 09:15:27AM -0600, Scott Long wrote: >>>> Andrey A. Chernov wrote: >>>>> ache 2007-10-15 09:51:30 UTC >>>>> FreeBSD src repository >>>>> Modified files: >>>>> lib/libc/locale utf8.c Log: >>>>> Add comment explaining __mb_sb_limit trick here. >>>>> Revision Changes Path >>>>> 1.16 +5 -0 src/lib/libc/locale/utf8.c >>>> When is the ABI damage from this going to be fixed? >>> There is no ABI damage in -current. >> Do we really need to expose __mb_sb_limit outside libc? >=20 > Yes, it is used in inlines compiled each time ctype.h included. Yes, I noticed that. So the problem would be, if a program has included ctype.h (_ctype.h) then it has the potential to require the symbol, which does not exist in previous releases. Having __inline functions sounds reasonable to me, though, because these functions are really small and may be called frequently. Maybe we can think out a way of avoiding the addition? It sounds like that potentially we will have trouble running binaries compiled on 6.3-R on 6.2-R systems, while this is acceptable IMO it is not very interesting for user community :-) Cheers, --=20 Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! --------------enig9372C5B26114F9F41A4DDFE6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHIOnhOfuToMruuMARCkhMAJkBdIU8CJg4kjJBtVeJgquPPlKldwCZAYcr wpSbIb3xfLO4oG5e3o+MF6Y= =Gw2e -----END PGP SIGNATURE----- --------------enig9372C5B26114F9F41A4DDFE6--