From owner-freebsd-current@FreeBSD.ORG Wed Apr 17 10:07:54 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 79D3DFE3; Wed, 17 Apr 2013 10:07:54 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) by mx1.freebsd.org (Postfix) with ESMTP id 24BBD9F6; Wed, 17 Apr 2013 10:07:54 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::dc79:2881:589:7d77] (unknown [IPv6:2001:7b8:3a7:0:dc79:2881:589:7d77]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 4646E5C45; Wed, 17 Apr 2013 12:07:49 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Subject: Re: CURRENT (r249438): (devel/libiconv)./unistd.h:686:5: error: invalid token at start of a preprocessor expression : #if @GNULIB_EUIDACCESS@ From: Dimitry Andric In-Reply-To: <1USKxR-00025i-Tt@internal.tormail.org> Date: Wed, 17 Apr 2013 12:07:47 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <1365877246.2093.20.camel@thor.walstatt.dyndns.org> <1URs5b-000B9U-A2@internal.tormail.org> <1USKxR-00025i-Tt@internal.tormail.org> To: Jan Beich X-Mailer: Apple Mail (2.1503) Cc: FreeBSD Current , "O. Hartmann" , FreeBSD ports X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2013 10:07:54 -0000 On Apr 17, 2013, at 07:31, Jan Beich wrote: > Dimitry Andric writes: > On Apr 16, 2013, at 00:42, Jan Beich wrote: ... >>> Maybe -O3 overoptimizes regex in libc e.g., >>>=20 >>> $ echo '#if @GNULIB_EUIDACCESS@' | sed 's/@GNULIB_EUIDACCESS@/0/' >>> #if @GNULIB_EUIDACCESS@ >>>=20 >>> $ echo 'aaaaaaaaaaaaaaaaxxxaaaa' | sed 's/aaaaaaaaaaaaxxxaaaa//' >>> aaaaaaaaaaaaaaaaxxxaaaa >>=20 >> How did you arrive at this result? >=20 > 1/ chroot into poudriere jail for /head amd64 > 2/ echo CFLAGS+=3D-O3 >> /etc/make.conf > 3/ make -j2 (in /usr/src/lib/libc) > 4/ prepend LD_LIBRARY_PATH=3D. before sed(1) > 5/ rebuild regcomp.o, regcomp.So with -O2 to confirm I have been able to reproduce this on amd64, with -O3, but not on i386. It seems regcomp() is either miscompiled at -O3, or it contains some bug triggered only by the vectorizer. I am still investigating. > My luck is poor even with -O2 e.g., firefox20 crash on = stackoverflow.com >=20 > [New LWP 101222] > [New Thread 801b02400 (LWP 101222)] > [New Thread 81060e800 (LWP 101372 StreamTrans #1)] > [New Thread 810ee8800 (LWP 101373 DOM Worker)] >=20 > Program received signal SIGSEGV, Segmentation fault. > [Switching to Thread 801b02400 (LWP 101222)] > PodCopy (dst=3D, nelem=3D, > src=3D, dst=3D, src=3D, > nelem=3D) at ../../../js/src/jsutil.h:238 > 238 PodAssign(dst, src); > (gdb) bt > #0 PodCopy (dst=3D, nelem=3D, > src=3D, dst=3D, src=3D, > nelem=3D) at ../../../js/src/jsutil.h:238 > #1 getCallFrame (cx=3D, flags=3D, = fun=3D, > report=3D(unknown: 2266652928), this=3D, args=3D..., = script=3D...) > at ../../../js/src/vm/Stack-inl.h:454 > #2 getFixupFrame (cx=3D, initial=3D, > fun=3D, ncode=3D, dummy=3D0, = report=3D, > this=3D, cx=3D, report=3D, args=3D..., > fun=3D, script=3D..., ncode=3D, > initial=3D, stackLimit=3D) > at ../../../js/src/vm/Stack-inl.h:513 > #3 js::mjit::stubs::FixupArity (f=3D..., nactual=3D4294945312) > at = /wrkdirs/usr/ports/www/firefox/work/mozilla-release/js/src/methodjit/Invok= eHelpers.cpp:213 > #4 0x00000008019c48c2 in ?? () > #5 0x00000008019b56b8 in ?? () > #6 0x0000000000000001 in ?? () > #7 0x0000000000000000 in ?? () This is a completely different issue. Is there any way you can reduce the test case? Or maybe upstream has already fixed it?