Date: Fri, 20 Jun 2014 20:55:21 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-fs@FreeBSD.org Subject: [Bug 187594] [zfs] [patch] ZFS ARC behavior problem and fix Message-ID: <bug-187594-3630-xoAKc8tSXS@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-187594-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-187594-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=187594 --- Comment #19 from Adrian Chadd <adrian@freebsd.org> --- >From alc: I gave it a cursory look. The patch appears to use "vm_cnt.v_free_target" incorrectly. If you look at sys/vmmeter, specifically, /* * Return TRUE if we have not reached our free page target during * free page recovery operations. */ static __inline int vm_page_count_target(void) { return (vm_cnt.v_free_target > (vm_cnt.v_free_count + vm_cnt.v_cache_count)); } /* * Return the number of pages we need to free-up or cache * A positive number indicates that we do not have enough free pages. */ static __inline int vm_paging_target(void) { return (vm_cnt.v_free_target - (vm_cnt.v_free_count + vm_cnt.v_cache_count)); } you see that "vm_cnt.v_free_target" should be compared to "(vm_cnt.v_free_count + vm_cnt.v_cache_count)" not "vm_cnt.v_free_count". -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-187594-3630-xoAKc8tSXS>