From owner-svn-ports-all@freebsd.org Sat Mar 6 11:20:35 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 61664562745; Sat, 6 Mar 2021 11:20:35 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dt2GC2NHwz3lLx; Sat, 6 Mar 2021 11:20:35 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from marvin.madpilot.net (host-87-6-127-217.retail.telecomitalia.it [87.6.127.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id B3D6F217E5; Sat, 6 Mar 2021 11:20:34 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Subject: Re: svn commit: r567405 - in head/games/0ad: . files To: Piotr Kubaj Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202103051851.125IpWM7053002@repo.freebsd.org> From: Guido Falsi Message-ID: <79628989-f040-9caf-40a5-ff7ec30be2e2@FreeBSD.org> Date: Sat, 6 Mar 2021 12:20:33 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Mar 2021 11:20:35 -0000 On 05/03/21 21:13, Piotr Kubaj wrote: > On 21-03-05 18:51:32, Guido Falsi wrote: >> Author: madpilot >> Date: Fri Mar 5 18:51:31 2021 >> New Revision: 567405 >> URL: https://svnweb.freebsd.org/changeset/ports/567405 >> >> Log: >> - Import patches for powerpc64le >> - Force the -msse2 option only for i386 where it is actually needed >> >> PR: 253924 >> Submitted by: pkubaj@ >> >> Added: >> head/games/0ad/files/patch-libraries_source_nvtt_src_src_nvcore_Debug.cpp (contents, props changed) >> head/games/0ad/files/patch-source_lib_byte__order.h (contents, props changed) >> head/games/0ad/files/patch-source_lib_sysdep_arch.h (contents, props changed) >> head/games/0ad/files/patch-source_lib_sysdep_arch_ppc64_ppc64.cpp (contents, props changed) >> head/games/0ad/files/patch-source_ps_GameSetup_HWDetect.cpp (contents, props changed) >> Modified: >> head/games/0ad/Makefile >> head/games/0ad/files/patch-build_premake_premake5.lua >> >> Modified: head/games/0ad/Makefile >> ============================================================================== >> --- head/games/0ad/Makefile Fri Mar 5 18:28:34 2021 (r567404) >> +++ head/games/0ad/Makefile Fri Mar 5 18:51:31 2021 (r567405) >> @@ -45,7 +45,6 @@ WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}-alpha >> BUILD_WRKSRC= ${WRKSRC}/build/workspaces/gcc >> MAKE_ARGS= config=release verbose=1 >> CPPFLAGS+= -DU_USING_ICU_NAMESPACE=1 >> -CFLAGS+= -msse2 >> BUNDLE_LIBS= yes >> DOS2UNIX_REGEX= .*\.([ch]p{0,2}|make) >> BINARY_ALIAS= python3=${PYTHON_CMD} >> @@ -57,6 +56,10 @@ MAKE_ENV+= JOBS=${_MAKE_JOBS} >> PORTDATA= * >> >> .include >> + >> +.if ${ARCH} == i386 >> +CFLAGS+= -msse2 >> +.endif > > Instead of this, you could just set: > CFLAGS_i386= -msse2 > right below CPPFLAGS+= -DU_USING_ICU_NAMESPACE=1 > Done, thanks for the suggestion! -- Guido Falsi