From owner-svn-src-all@FreeBSD.ORG Sun Jul 13 18:50:55 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5970FFB7; Sun, 13 Jul 2014 18:50:55 +0000 (UTC) Received: from mail-qc0-x22a.google.com (mail-qc0-x22a.google.com [IPv6:2607:f8b0:400d:c01::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DC40C2F7C; Sun, 13 Jul 2014 18:50:54 +0000 (UTC) Received: by mail-qc0-f170.google.com with SMTP id c9so2789703qcz.29 for ; Sun, 13 Jul 2014 11:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=eR+nGK6ifkanV3MDytMMsYyl1xrDYl48eQ8GGXTKGdg=; b=vwh3VfsIc3QC4WgoP+wQnGT0V1eD07GuA5Fcg0I3JBSoxt9H4cSnPCq9vzmUmjR4KR Zs8iLLuZvlzDYzSki9tzG7p6Ja52OEGZEG58CLnuVrKjOFcoLMyjX2mZjcWD/iT3kJ9S A4FSbTKXfg0HeBjJhbRwdb5/a2qHv1ex2v0BILu7uzcZLPtreKWdqhlAB0965XW9aui7 LrARUx3TZjqhtj2mi2nqmivEVtoIjJYAoNlAWI5GMp2ubnIXGcxJLT0pFmAoaCpM+1Qg aKaeph139DN0SQ0d23vvlAv5KtXpKc5Bk5if1JpzBLLTCtoYPbCu5FM5la7e6qnykREB BE5w== MIME-Version: 1.0 X-Received: by 10.140.47.48 with SMTP id l45mr17998732qga.24.1405277454005; Sun, 13 Jul 2014 11:50:54 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.202.193 with HTTP; Sun, 13 Jul 2014 11:50:53 -0700 (PDT) In-Reply-To: <201407131031.s6DAVTja093433@svn.freebsd.org> References: <201407131031.s6DAVTja093433@svn.freebsd.org> Date: Sun, 13 Jul 2014 11:50:53 -0700 X-Google-Sender-Auth: snSl-DxV492Q-vu7X8tDhy5Pv1I Message-ID: Subject: Re: svn commit: r268584 - head/sys/dev/sound/pci/hda From: Adrian Chadd To: Mark Johnston Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jul 2014 18:50:55 -0000 Hi! So I have an X230 and a T400 - both require fiddling of the default sound unit sysctl when I want to use headphones. Does this above patch outline what I need to do to get it working dynamically? -a On 13 July 2014 03:31, Mark Johnston wrote: > Author: markj > Date: Sun Jul 13 10:31:29 2014 > New Revision: 268584 > URL: http://svnweb.freebsd.org/changeset/base/268584 > > Log: > Add a headphone redirection quirk for the Lenovo G580. > > MFC after: 1 week > > Modified: > head/sys/dev/sound/pci/hda/hdaa_patches.c > head/sys/dev/sound/pci/hda/hdac.h > > Modified: head/sys/dev/sound/pci/hda/hdaa_patches.c > ============================================================================== > --- head/sys/dev/sound/pci/hda/hdaa_patches.c Sun Jul 13 09:34:59 2014 (r268583) > +++ head/sys/dev/sound/pci/hda/hdaa_patches.c Sun Jul 13 10:31:29 2014 (r268584) > @@ -350,7 +350,8 @@ hdac_pin_patch(struct hdaa_widget *w) > (subid == LENOVO_X1_SUBVENDOR || > subid == LENOVO_X220_SUBVENDOR || > subid == LENOVO_T420_SUBVENDOR || > - subid == LENOVO_T520_SUBVENDOR)) { > + subid == LENOVO_T520_SUBVENDOR || > + subid == LENOVO_G580_SUBVENDOR)) { > switch (nid) { > case 25: > patch = "as=1 seq=15"; > > Modified: head/sys/dev/sound/pci/hda/hdac.h > ============================================================================== > --- head/sys/dev/sound/pci/hda/hdac.h Sun Jul 13 09:34:59 2014 (r268583) > +++ head/sys/dev/sound/pci/hda/hdac.h Sun Jul 13 10:31:29 2014 (r268584) > @@ -241,6 +241,7 @@ > #define LENOVO_T430S_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21fb) > #define LENOVO_T520_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21cf) > #define LENOVO_T530_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21f6) > +#define LENOVO_G580_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x3977) > #define LENOVO_ALL_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0xffff) > > /* Samsung */ >