From nobody Thu Mar 26 15:08:17 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fhRwy0j4Yz6RfJd for ; Thu, 26 Mar 2026 15:08:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fhRwx6Xznz3n2K for ; Thu, 26 Mar 2026 15:08:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774537698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KNNJxL+V7Dnw3z9TDLh99e0TGt4p6tVyMYr6qNkg46Q=; b=JlTv1JHAqIIOg8d2jnuYM3+7876xMl81dURaKYyQbQFukjE0J3y3wnUQu7lli5mEVsCJ9/ Z+x5aiehCTnR9IiTzpdGL+Z+l6q6snzERit+on0ukN3U4fNgtvJXhDNNqtWvv8J+Ci5pB+ FPbR+2dNsEPGe5fLyECfU1k7s6E34fWCZkS+asm1sGErLS/ew0+q5hrTfCAM0XpikPOdaf CX3iRRAT40KxuLggL26sbbky/1NFvJsDcnx2BwGk4KRHdchsD8uN2LBWVB0WrEAEB7GtyJ NGoW0lq4VB65ndnelZ+c4Hk6Ka3cfQFGYeVl4/vhFVhkJy91/Osa4tHVdqVBbw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774537698; a=rsa-sha256; cv=none; b=LehPldNH54JQnFLpvcyEIgcbP0N7Mw1xSPGVg4K58V2g8eQsXBeMWWwHk6gGKT2+GEiP5l P+M6cJ7Ntet7+PsQfGeqFqlPL1b95DLeKnr+5R3LSYeH9y2pZXGH0nxLKLAWalaxRMKMbN RCdIm0irQZn2UBEqRp1fTJYD3b3AFE720cB43/q81HBWz2QlrKPCmpsn2cmsbEhORH5OQ6 nJ8kjap8FEgdxBOf3XZzAYrNPPBKl9BD3I5EibXCn7fsis03d/GTMYivM0obGl1ByBy3e/ 45FiScqA7gTB4gGxXXhrwbAUEKrVUZw1Wug240QA2hGXnbvqk/BRS4C5x/T0jg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774537697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KNNJxL+V7Dnw3z9TDLh99e0TGt4p6tVyMYr6qNkg46Q=; b=tdSDD1FROM4rXGacm5S0p+vsOtKwD+FetrTOf68/U3RnfgAlYocQw7a2Uksgp9g/zRPgdL BLJx8EVqWjH6I1xBrdsE2pG5MhrhfuULxNDwUNxHYxMRE4gdyALLdhBqy68V+Ds3aEjoQd ERfotRBPx3eDLOzxJeR1Q3nauZNDiwgUyy0BMG0Xl6zXHjGyjS7aSyDAdIaJSpJci+XdOs DZF/spN8E9PpNRc9jovC2LIjjWQNy/JcpMJHeGoL29CA9xcWXFW0kH3+fFXwszzPHNRrzS 377gnnnDr8lFml6SileLHSGl3GdjY8OTxJpqOtUrGmHEVmGn4vyvAvziK9PhCw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fhRwx62XCzxZF for ; Thu, 26 Mar 2026 15:08:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 205fe by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 26 Mar 2026 15:08:17 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alan Somers Subject: git: d0692508bc40 - stable/15 - fusefs: remove the obsolete rename_lock List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: d0692508bc40ee7e06609e7421767a6a3d15c5de Auto-Submitted: auto-generated Date: Thu, 26 Mar 2026 15:08:17 +0000 Message-Id: <69c54be1.205fe.7ebe74de@gitrepo.freebsd.org> The branch stable/15 has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=d0692508bc40ee7e06609e7421767a6a3d15c5de commit d0692508bc40ee7e06609e7421767a6a3d15c5de Author: Alan Somers AuthorDate: 2026-02-10 20:45:23 +0000 Commit: Alan Somers CommitDate: 2026-03-26 15:02:12 +0000 fusefs: remove the obsolete rename_lock This lock was included in the original GSoC submission. Its purpose seems to have been to prevent concurrent FUSE_RENAME operations for the current mountpoint, as well as to synchronize FUSE_RENAME with fuse_vnode_setparent. But it's obsolete, now that ef6ea91593e added mnt_renamelock . Sponsored by: ConnectWise Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D55231 (cherry picked from commit 7755a406a6ae3801e885a79f714155f97c4d2bc6) --- sys/fs/fuse/fuse_ipc.c | 2 -- sys/fs/fuse/fuse_ipc.h | 2 -- sys/fs/fuse/fuse_vnops.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/sys/fs/fuse/fuse_ipc.c b/sys/fs/fuse/fuse_ipc.c index bc36f0070d7d..3810313124b6 100644 --- a/sys/fs/fuse/fuse_ipc.c +++ b/sys/fs/fuse/fuse_ipc.c @@ -550,7 +550,6 @@ fdata_alloc(struct cdev *fdev, struct ucred *cred) TAILQ_INIT(&data->aw_head); data->daemoncred = crhold(cred); data->daemon_timeout = FUSE_DEFAULT_DAEMON_TIMEOUT; - sx_init(&data->rename_lock, "fuse rename lock"); data->ref = 1; return data; @@ -565,7 +564,6 @@ fdata_trydestroy(struct fuse_data *data) return; /* Driving off stage all that stuff thrown at device... */ - sx_destroy(&data->rename_lock); crfree(data->daemoncred); mtx_destroy(&data->aw_mtx); knlist_delete(&data->ks_rsel.si_note, curthread, 0); diff --git a/sys/fs/fuse/fuse_ipc.h b/sys/fs/fuse/fuse_ipc.h index d9d79f38c269..374d0891617d 100644 --- a/sys/fs/fuse/fuse_ipc.h +++ b/sys/fs/fuse/fuse_ipc.h @@ -194,8 +194,6 @@ struct fuse_data { */ u_long ticketer; - struct sx rename_lock; - uint32_t fuse_libabi_major; uint32_t fuse_libabi_minor; diff --git a/sys/fs/fuse/fuse_vnops.c b/sys/fs/fuse/fuse_vnops.c index 3bfc5396c365..e3d475135c90 100644 --- a/sys/fs/fuse/fuse_vnops.c +++ b/sys/fs/fuse/fuse_vnops.c @@ -2193,7 +2193,6 @@ fuse_vnop_rename(struct vop_rename_args *ap) if (err) goto out; } - sx_xlock(&data->rename_lock); err = fuse_internal_rename(fdvp, fcnp, tdvp, tcnp); if (err == 0) { if (tdvp != fdvp) @@ -2201,7 +2200,6 @@ fuse_vnop_rename(struct vop_rename_args *ap) if (tvp != NULL) fuse_vnode_setparent(tvp, NULL); } - sx_unlock(&data->rename_lock); if (tvp != NULL && tvp != fvp) { cache_purge(tvp);