From owner-freebsd-questions  Wed Feb  5 14:00:49 1997
Return-Path: <owner-questions>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id OAA15365
          for questions-outgoing; Wed, 5 Feb 1997 14:00:49 -0800 (PST)
Received: from root.com (implode.root.com [198.145.90.17])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id OAA15345;
          Wed, 5 Feb 1997 14:00:42 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by root.com (8.7.6/8.6.5) with SMTP id OAA11374; Wed, 5 Feb 1997 14:00:50 -0800 (PST)
Message-Id: <199702052200.OAA11374@root.com>
X-Authentication-Warning: implode.root.com: Host localhost [127.0.0.1] didn't use HELO protocol
To: Brian McGovern <bmcgover@cisco.com>
cc: support@freebsd.org, hackers@freebsd.org
Subject: Re: Stomp the bug!!!! (Was cyclades bug) 
In-reply-to: Your message of "Wed, 05 Feb 1997 16:26:57 EST."
             <199702052126.QAA00718@bmcgover-pc.cisco.com> 
From: David Greenman <dg@root.com>
Reply-To: dg@root.com
Date: Wed, 05 Feb 1997 14:00:50 -0800
Sender: owner-questions@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

>Boy, I hate when things are obvious.
>
>The line:
>
>outw(ioport + CY_PLX_ICS, inw(CY_PLX_ICS) | 
>	CY_PLX_ICS_IENABLE | CY_PLX_ICS_LOCAL_IENABLE);
>
>is wrong. The inw doesn't have the ioport offset, and should read:
>
>outw(ioport + CY_PLX_ICS, inw(ioport + CY_PLX_ICS) | 
>	CY_PLX_ICS_IENABLE | CY_PLX_ICS_LOCAL_IENABLE);
>
>
>Otherwise, the inw doesn't read from the same register as you outw to. If
>someome would like me to diff this up, let me know. Otherwise, I'll assume
>the change will get committed?
>
>Gee, I feel good. My first bug fix.

   THANKS!!! Yes, that is indeed a stupid bug and likely causes all sorts of
bad things to happen.

-DG

David Greenman
Core-team/Principal Architect, The FreeBSD Project