From owner-cvs-src@FreeBSD.ORG Wed Apr 11 11:40:29 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 15DCE16A401 for ; Wed, 11 Apr 2007 11:40:29 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by mx1.freebsd.org (Postfix) with ESMTP id 7934413C48C for ; Wed, 11 Apr 2007 11:40:26 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by core.fnop.net (Postfix) with ESMTP id 8253968FEE8; Wed, 11 Apr 2007 12:38:50 +0100 (WEST) Received: by core.fnop.net (Postfix, from userid 1015) id 27E9F69027A; Wed, 11 Apr 2007 12:38:50 +0100 (WEST) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on core.fnop.net X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_00, FORGED_RCVD_HELO,RCVD_IN_SORBS_DUL autolearn=no version=3.1.7 Received: from epsilon.local (87-196-29-209.net.novis.pt [87.196.29.209]) by core.fnop.net (Postfix) with ESMTP id A1D6E68FEE8; Wed, 11 Apr 2007 12:38:48 +0100 (WEST) Message-ID: <461CC925.5090400@fnop.net> Date: Wed, 11 Apr 2007 12:40:21 +0100 From: Rui Paulo User-Agent: Thunderbird 2.0b2 (Macintosh/20070116) MIME-Version: 1.0 To: Pyun YongHyeon References: <200704110047.l3B0lTcE093763@repoman.freebsd.org> In-Reply-To: <200704110047.l3B0lTcE093763@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/msk if_msk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2007 11:40:29 -0000 Pyun YongHyeon wrote: > yongari 2007-04-11 00:47:29 UTC > > FreeBSD src repository > > Modified files: > sys/dev/msk if_msk.c > Log: > Add work around for hardware Tx checksum offload bug in Yukon II. > Yukon II generated corrupted TCP checksum for short TCP packets > that's less than 60 bytes in size(e.g. window probe packet, pure ACK > packet etc). Padding the frame with zeros to make the frame minimum > ethernet frame size didn't work at all. Instead of dropping Tx > checksum offload support we calculate TCP checksum with S/W method > when we encounter short TCP frames. > Fortunately it seems that short UDP datagrams appear to be handled > correctly by Yukon II. > > While I'm here simplify ethernet/VLAN header size calculation logic. Thanks! :) -- Rui Paulo | PGP: F0E4 C7C7 1653 79B7 78DC DD73 64FA B2C6 CF45 1F84