From nobody Wed Sep 21 14:01:03 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MXg732Jqtz4cXyj; Wed, 21 Sep 2022 14:01:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MXg731sPhz47F1; Wed, 21 Sep 2022 14:01:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663768863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZaOkhG16KGXNNS66aoGzaowSo8vLWRnTw+ghtK7/l54=; b=fuODuFYsVQ9xarJn0p7L5l1zeub5OUKV2awm8DWkZRJrXk3FVBBhV6sL7T6lksOqC6nSYa 6W/TPblBA5U8vmr3Ewh2qxJG/HN08vDb3QwBY8055DnQtoi2yjo757M/R6DvBFpYQhtyOW 2JnovvO2GtMlqTXJOKedb62TLOAgJKH0nmn+Gb4yzJZTXUNwU83w9J1DzJyJvnRofb/5Wz es8orfM/C/btd7V77/s9za4wnSlEpjjffbMO/x67/YhOMhbiq73qHgUcDyQSY+kN5jFH36 uwUSggRfsGxOCZPxtXUwFu+xx0L0bgbj3SpSlXG4OpaUzGrqZPTemEvq71QVQA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MXg730vRSz14xm; Wed, 21 Sep 2022 14:01:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 28LE13ON099525; Wed, 21 Sep 2022 14:01:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 28LE133e099524; Wed, 21 Sep 2022 14:01:03 GMT (envelope-from git) Date: Wed, 21 Sep 2022 14:01:03 GMT Message-Id: <202209211401.28LE133e099524@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 4c9650ac3162 - stable/13 - ifconfig: print interface name on SIOCIFCREATE2 error List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 4c9650ac316214c7819fefdd20df766ea8c2b854 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663768863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZaOkhG16KGXNNS66aoGzaowSo8vLWRnTw+ghtK7/l54=; b=KKEAQqBKMqrgWUY602WGertIAcBf6hiWm4goUfR+LjOpy7OMgIu4nVawxt+NsuiS2otNhb jJX7EDPQZEIpdw6xo1EldS7f8Ld2WMapYXUIDJNo+kQ8t4R6b1rhWd5B4e08OSmyeBfLz4 n+6szBgPF/meakIOjOGDN0tdIfqzJJBPq0e/BEKXfIjtmHqvGxCwvtt8EmMm5Sh4nMkeZv fFvnO0l+RBkqbtDBMduITBwaqwFX7+buF1JkwgoqMRKdXgsNk2HJhtH6FjQWR9s761Tsu3 Oi7EiXPUU8wpHSrrYR3s9NAKesI98hCQgc1QCDS1hhCIRJ+mmk+Rn47pZQNmnw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663768863; a=rsa-sha256; cv=none; b=OryiQ34xZO7g+xYRnslmYoUro8gg15uv9R4jR6sSdnE/qcNPRLFabARy0ba21fprAUsyDP d+pjhFKoNjYb5o7pPN8+4DgzZVZpJ0LwPut8G4ZTPneYCuXui+WT4JUkMiPW6Yrxy5AHqp ifaKfGPrpOg20Oz7IIz4ef9BmdP8Q29/n/ut0ArxYX588s4TIVikKv9dObT7LRQAcLr0AL wPJcwkZHbXqj+JIE2Z9dVhzmGYciUz2Wm/EaaPet0t7xAQoFfwV1vu736aAIqSHGx9tmac GpgtI83cWiDCvEAb7bUdpC/GRLAdMbeHMHpJszVwnhtzQI2BvcuUdQr1qHVLVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=4c9650ac316214c7819fefdd20df766ea8c2b854 commit 4c9650ac316214c7819fefdd20df766ea8c2b854 Author: Bjoern A. Zeeb AuthorDate: 2022-09-06 13:09:39 +0000 Commit: Bjoern A. Zeeb CommitDate: 2022-09-21 11:39:13 +0000 ifconfig: print interface name on SIOCIFCREATE2 error We have repeatedly gotten reports of unclassified SIOCIFCREATE2 errors (usually "Device not configured"). This can happen if there is configuration for interfaces in rc.conf which do not (yet) exist and we try to configure. I can, e.g., provoke this by configuring wlan interfaces with their physical interface not installed. In order to cut support (guesswork) down print the name of the interface to be configured with the error message. Hopefully this will help us in the future to improve other configuration or driver problems. Sponsored by: The FreeBSD Foundation (cherry picked from commit ac606903a800bc4ce80bc6fa1374b45efcdb7014) --- sbin/ifconfig/ifconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/ifconfig/ifconfig.c b/sbin/ifconfig/ifconfig.c index 9e7d38d4c2a4..f01f40e46a8b 100644 --- a/sbin/ifconfig/ifconfig.c +++ b/sbin/ifconfig/ifconfig.c @@ -207,7 +207,7 @@ ioctl_ifcreate(int s, struct ifreq *ifr) case EEXIST: errx(1, "interface %s already exists", ifr->ifr_name); default: - err(1, "SIOCIFCREATE2"); + err(1, "SIOCIFCREATE2 (%s)", ifr->ifr_name); } } }