Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 01 Nov 2013 15:24:52 +0400
From:      Boris Samorodov <bsam@passap.ru>
To:        Ryan Steinmetz <zi@FreeBSD.org>, ports-committers@freebsd.org,  svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r332334 - in head/finance: . vanitygen
Message-ID:  <52738F84.8060906@passap.ru>
In-Reply-To: <201311010112.rA11Ch1h047872@svn.freebsd.org>
References:  <201311010112.rA11Ch1h047872@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi Ryan, All,

01.11.2013 05:12, Ryan Steinmetz пишет:

> Log:
>   New port: finance/vanitygen:

Thank you for working on new ports. It's always good to get a new one.
However there are some notes inlined.

> +MAINTAINER=	ports@FreeBSD.org

I'm not sure that a new unmaintained port is welcomed.

> +COMMENT=	A standalone vanity address generator for bitcoin

Articles should not be used at the beginning of a COMMENT.

> +LIB_DEPENDS=	pcre:${PORTSDIR}/devel/pcre

A new LIB_DEPENDS syntax is preferred.

> +NO_STAGE=	yes

I think that new ports are supposed to support STAGE.

-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52738F84.8060906>