From owner-cvs-src@FreeBSD.ORG  Tue Nov  4 14:19:46 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1E39B16A4CE; Tue,  4 Nov 2003 14:19:46 -0800 (PST)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E013E43FA3; Tue,  4 Nov 2003 14:19:44 -0800 (PST)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.9p2/8.12.9) with ESMTP id hA4MJgeG054420;
	Tue, 4 Nov 2003 15:19:43 -0700 (MST)
	(envelope-from imp@bsdimp.com)
Date: Tue, 04 Nov 2003 15:18:35 -0700 (MST)
Message-Id: <20031104.151835.56048891.imp@bsdimp.com>
To: sam@errno.com
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200311040910.54728.sam@errno.com>
References: <39997.1067935555@critter.freebsd.dk>
	<200311040910.54728.sam@errno.com>
X-Mailer: Mew version 2.1 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: phk@phk.freebsd.dk
cc: src-committers@FreeBSD.org
cc: mckusick@FreeBSD.org
cc: cvs-src@FreeBSD.org
cc: silby@silby.com
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_timeout.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Nov 2003 22:19:46 -0000

In message: <200311040910.54728.sam@errno.com>
            Sam Leffler <sam@errno.com> writes:
: On Tuesday 04 November 2003 12:45 am, Poul-Henning Kamp wrote:
: > In message <20031104022403.J625@odysseus.silby.com>, Mike Silbersack writes:
: > >On Tue, 4 Nov 2003, Kirk McKusick wrote:
: > >> mckusick    2003/11/04 00:03:11 PST
: > >>
: > >>   FreeBSD src repository
: > >>
: > >>   Modified files:
: > >>     sys/kern             kern_timeout.c
: > >>   Log:
: > >>   Get rid of DIAGNOSTIC that gives false positives on slow CPUs.
: > >
: > >That doesn't seem to be a very good reason for removing the code.  As only
: > >the highest value seen so far is printed, the code is generally pretty
: > >quiet once it stops complaining about how long the MII routines take.
: >
: > I agree, I am unhappy about this removal too.
: 
: Please revert this change.

It seems to me that DIAGNOSTIC should be disabled on those slow CPUs.
How slow do you need to trigger the bug?  If slow is 1GHz that's one
thing, but if slow is 166MHz, then that's another :-)

Please revert.  If you are unhappy about false positives, then the
timeout interval likely should be tuned.

Warner