From owner-cvs-all@FreeBSD.ORG  Mon Feb 16 10:59:43 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1A35416A4CE; Mon, 16 Feb 2004 10:59:43 -0800 (PST)
Received: from chiark.greenend.org.uk (chiark.greenend.org.uk
	[193.201.200.170])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E4C5543D1D; Mon, 16 Feb 2004 10:59:42 -0800 (PST)
	(envelope-from fanf@chiark.greenend.org.uk)
Received: by chiark.greenend.org.uk (Debian Exim 3.35 #1) with local
	id 1Asny2-0003gE-00; Mon, 16 Feb 2004 18:59:42 +0000
Date: Mon, 16 Feb 2004 18:59:42 +0000
From: Tony Finch <dot@dotat.at>
To: Robert Watson <rwatson@FreeBSD.org>
Message-ID: <20040216185942.GP17809@chiark.greenend.org.uk>
References: <200402161841.i1GIfwmv008267@repoman.freebsd.org>
	<Pine.NEB.3.96L.1040216134648.63057L-100000@fledge.watson.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.NEB.3.96L.1040216134648.63057L-100000@fledge.watson.org>
User-Agent: Mutt/1.3.28i
Sender: Tony Finch <fanf@chiark.greenend.org.uk>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Dag-Erling Smorgrav <des@FreeBSD.org>
Subject: Re: cvs commit: src/sys/vm vm_kern.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Feb 2004 18:59:43 -0000

On Mon, Feb 16, 2004 at 01:55:51PM -0500, Robert Watson wrote:
> On Mon, 16 Feb 2004, Dag-Erling Smorgrav wrote:
> > 
> >   Don't panic if we fail to satisfy an M_WAITOK request; return 0 instead.
> >   The calling code will either handle that gracefully or cause a page fault.
> 
> This substantially modifies the semantics of the two consumers of
> kmem_malloc(), and those semantic changes trickle up the stack to a number
> of important places.  Are you going to update the consumers (and their
> comments) as well?

ISTR that the whole point of M_WAITOK when it was introduced was that
callers could rely on the fact that it would not return NULL.

Tony.
-- 
f.a.n.finch  <dot@dotat.at>  http://dotat.at/
RATTRAY HEAD TO BERWICK ON TWEED: WEST 2 OR 3 INCREASING NORTHWEST 4 OR 5
LOCALLY 6 THEN DECREASING 3 LOCALLY 4 OR 5. PATCHY RAIN AT FIRST, THEN FINE
AND DRY. GENERALLY GOOD, BUT PERHAPS LOCALLY MODERATE IN RAIN. SLIGHT.