From owner-freebsd-gecko@FreeBSD.ORG Tue Sep 22 18:42:05 2009 Return-Path: Delivered-To: gecko@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E1E4106568B; Tue, 22 Sep 2009 18:42:05 +0000 (UTC) (envelope-from andreast-list@fgznet.ch) Received: from smtp.fgznet.ch (mail.fgznet.ch [81.92.96.47]) by mx1.freebsd.org (Postfix) with ESMTP id A1A738FC26; Tue, 22 Sep 2009 18:42:03 +0000 (UTC) Received: from deuterium.andreas.nets ([91.190.8.131]) by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id n8MIg2qa078594; Tue, 22 Sep 2009 20:42:02 +0200 (CEST) (envelope-from andreast-list@fgznet.ch) Message-ID: <4AB91A7A.3030200@fgznet.ch> Date: Tue, 22 Sep 2009 20:42:02 +0200 From: Andreas Tobler User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: Beat Gaetzi References: <4AB667AF.7060108@fgznet.ch> <4AB8831D.4050203@FreeBSD.org> In-Reply-To: <4AB8831D.4050203@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: gecko@FreeBSD.org Subject: Re: [patch] Thunderbird powerpc port X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2009 18:42:05 -0000 Hoi Beat, Beat Gaetzi wrote: > Andreas Tobler wrote: >> it took a while since I needed to port a gdb for powerpc first. >> >> But here it is, this patch allows me to build AND run thunderbird on >> powerpc freebsd. > > Thanks a lot for this work. Welcome. It was fun :) >> The patch contains three parts, an already existing Makefile.in patch. >> A new set of files for powerpc and the bsd-gecko-mk patch. > > Is this modification in bsd.gecko.mk needed for all gecko ports on > powerpc or just for thunderbird? If its just for thunderbird please > remove inclusion of ${PORTSDIR}/www/mozilla/Makefile.common in Makefile > and add USE_GECKO= gecko somewhere near USE_GMAKE. With this > modification you should be able to use GECKO_PTHREAD_LIBS directly in > thunderbird Makefile. Aha. This is the trick. Well, beside Firefox35 and Thunderbird I did not build anything else which uses bsd.gecko.mk. But from the code pov I'd say every port suffers from this issue on powerpc. Maybe we can leave the bsd.gecko.mk for later. Currently I try your suggestion. Below is the diff for the Makefile. With this patch, the bsd.gecko.mk part is not needed. Still building. Gruss, Andreas --- Makefile.orig 2009-08-21 16:27:32.000000000 +0200 +++ Makefile 2009-09-22 20:14:27.000000000 +0200 @@ -2,13 +2,12 @@ # Date created: 4 September 2003 # Whom: Joe Marcus Clarke # -# $FreeBSD: ports/mail/thunderbird/Makefile,v 1.105 2009/07/23 07:46:42 ale Exp $ +# $FreeBSD: ports/mail/thunderbird/Makefile,v 1.106 2009/08/22 11:52:00 beat Exp $ # $MCom: ports-stable/mail/thunderbird/Makefile,v 1.18 2009/01/02 21:16:20 mezz Exp $ # PORTNAME= thunderbird -DISTVERSION= 2.0.0.22 -PORTREVISION= 1 +DISTVERSION= 2.0.0.23 CATEGORIES= mail ipv6 MASTER_SITES= ${MASTER_SITE_MOZILLA_EXTENDED} MASTER_SITE_SUBDIR= thunderbird/releases/${DISTVERSION}/source @@ -24,6 +23,7 @@ HAS_CONFIGURE= yes USE_BZIP2= yes USE_GMAKE= yes +USE_GECKO= gecko WANT_PERL= yes MOZ_EXTENSIONS= wallet,spellcheck,xmlextras,webservices,auth,transformiix @@ -44,7 +44,9 @@ .include -GECKO_PTHREAD_LIBS!=${CC} -dumpspecs | ${GREP} pthread | ${SED} -e 's|^.*%{\!pg: %{pthread:|| ; s|}.*$$||' || ${TRUE} +GECKO_PTHREAD_LIBS!=${CC} -dumpspecs | ${GREP} -m 1 '%{\!pg: %{pthread:' | ${SED +} -e 's|^.*%{\!pg: %{pthread:|| ; s|}.*$$||' || ${TRUE} + .if (${ARCH}=="sparc64" && ${OSVERSION} < 601101) IGNORE= core dumps on ${ARCH}, kern.osreldate>=601101 needed @@ -89,5 +91,4 @@ ${INSTALL_DATA} ${WRKSRC}/other-licenses/branding/${PORTNAME}/default.xpm \ ${PORTNAME_ICON} -.include "${PORTSDIR}/www/mozilla/Makefile.common" .include