From owner-p4-projects@FreeBSD.ORG  Thu Mar  4 00:14:39 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 900DD16A4D0; Thu,  4 Mar 2004 00:14:39 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5ADDE16A4CE; Thu,  4 Mar 2004 00:14:39 -0800 (PST)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DE10543D49; Thu,  4 Mar 2004 00:14:38 -0800 (PST)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.10/8.12.9) with ESMTP id i248Eckj087956;
	Thu, 4 Mar 2004 01:14:38 -0700 (MST)
	(envelope-from imp@bsdimp.com)
Date: Thu, 04 Mar 2004 01:47:36 -0700 (MST)
Message-Id: <20040304.014736.66275231.imp@bsdimp.com>
To: peter@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200403040632.i246WjMM020004@repoman.freebsd.org>
References: <200403040632.i246WjMM020004@repoman.freebsd.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: perforce@freebsd.org
Subject: Re: PERFORCE change 48113 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Mar 2004 08:14:40 -0000

In message: <200403040632.i246WjMM020004@repoman.freebsd.org>
            Peter Wemm <peter@freebsd.org> writes:
: 	stl is a lost cause. I reread it, it needs major surgery, not
: 	 a mere splitup.  It uses the old pci and the old isa shims and
: 	 does inline i386 asm.  (ie: its a linux driver beaten up to
: 	 compile on freebsd)

Actually, there's no i386 asm that I saw in this driver when I was
doing the conversion.  It is not a linux driver converted to FreeBSD,
it was written natively for lots of BSDs and hasn't been kept up to
date (the Stallion Linux driver is terrible in comparison).  I'll
grant that it does use the old shim code, which is why I became
interested in it (and why I've started a conversion for it).

Warner