From owner-svn-src-all@freebsd.org Mon Dec 16 18:42:30 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9B8F21CBA93 for ; Mon, 16 Dec 2019 18:42:30 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47c99x59X4z4BJw for ; Mon, 16 Dec 2019 18:42:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x732.google.com with SMTP id 21so3329423qky.4 for ; Mon, 16 Dec 2019 10:42:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bvV+WUUYDUBE1b3mutBPQ+7HtSKP3IqQ6tJ6J+Sgqjo=; b=l/TRb71aFW/F0KdaqRea4DXUq5ImrS2crJYo8WkH2unEGRVHCDUanpCYrvZjtNPli6 F9ioRCF56kOsvZQ9MXyEQWz54oQ1iNKYX8SNIu1IfP3KejDBFlcd+8rcBcAwkV039lKu SFV5ca0PvUMYpsr+iKnLybrVhnGO3eVVy1D029evNWCYGKZu9bbn24Fxp+VTnt0QNyFJ iE94m2omQCIkTvaeizI5mJX0IhbF4Iv54B0lai5no6rTG32u8HTwLm5VU6MhCfRqxmTk /oW808lEyuQIj5s8kx9wzafsKYgMmseJPbi/yKdK/v3nlgPxS9kp4+3IWBNTxJfrAQsp 4pqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bvV+WUUYDUBE1b3mutBPQ+7HtSKP3IqQ6tJ6J+Sgqjo=; b=m4V9rMgTAh4J0g1wygtfKLbW1o0WXwmXUBxYVFNg+dCqI/1tVitHiSXDlKElepU1G5 jALvFO/y293rg3XHKukSDA+uL5yLjq71kJpTLA8TE+D43lBzYndvud+55ZFzu+HF8knl SUfPy45X2d1e3qh9Y+/FCbW0KB6kfWUOnu3nwW3moauNZmmtsDKU5piK7sZAKmrxDDTE hir2N2Z/jLhvThFJZHGvmx3+dfqvnpbafIPm2HUR5HW5nWySe4lKvFfOVviSYhZdP95P e0YHVKZpwgJZbxbwD9cnA/5cTHPQyV4kjOCh59QuF0rBkPuPOexXgtj58qRH7iecoYKj otow== X-Gm-Message-State: APjAAAVPVdQuvx9GI7TYvgc0CGVNNB6TN/xov+Z9ttTud8oZleGroKwm SPQAdI1r+7q+HyrTO3uUKYlC5H1xr8EWRR0104nXmw== X-Google-Smtp-Source: APXvYqx6n2SK5oQk9fFDIMpk+WCTgHY2hO95bQZH3jMRij4TRGKiQ1+mXfamWNPbn4Xa8m5y+DC89SZnTfcfI0Rpgi8= X-Received: by 2002:a37:4f8e:: with SMTP id d136mr678258qkb.495.1576521748154; Mon, 16 Dec 2019 10:42:28 -0800 (PST) MIME-Version: 1.0 References: <201912132232.xBDMW5LL074330@repo.freebsd.org> <201912151851.xBFIpLaX090429@gndrsh.dnsmgr.net> In-Reply-To: <201912151851.xBFIpLaX090429@gndrsh.dnsmgr.net> From: Warner Losh Date: Mon, 16 Dec 2019 11:42:16 -0700 Message-ID: Subject: Re: svn commit: r355737 - head/share/man/man9 To: "Rodney W. Grimes" Cc: Warner Losh , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 47c99x59X4z4BJw X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=l/TRb71a; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::732) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.71 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[9]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.71)[ip: (-9.38), ipnet: 2607:f8b0::/32(-2.19), asn: 15169(-1.90), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2019 18:42:30 -0000 On Sun, Dec 15, 2019, 11:51 AM Rodney W. Grimes wrote: > > Author: imp > > Date: Fri Dec 13 22:32:05 2019 > > New Revision: 355737 > > URL: https://svnweb.freebsd.org/changeset/base/355737 > > > > Log: > > Better copyright advice > > > > Document the common practices around copyrights with "all rights > reserved" in > > them as new copyright notices get added. > > > > It's an open question qhether to point people at the fact that since > the Berne > > convention was ratified, All rights reserved is largely obsolete. > > https://en.wikipedia.org/wiki/All_rights_reserved#Obsolescence has the > > details. The committer's guide will be revised shortly, and it's > likely that's a > > better place for this discussion. If not, I'll add a blurb here. > > > > Reviewed by: jhb@, brooks@ > > Differential Review: https://reviews.freebsd.org/D22800 > > I object to the a review that specifically invites people to it, > is authored and committed in anything short of 24 hours and more > reasonable to actually ALLOW people time to repond of 72 hours. > The project has no fixed policies around reviews and giving time. Several people did look at it and approve it before I committed it. Having said that, this isn't like you've lost your ability to say something forever now that this is in the tree. If you have suggestions to improvement, I'm all ears. I like your notion around (c) being noise, but I'll address that in the review. Warner Regards, > Rod > > > Better copyright advice > AcceptedPublic > Authored by imp on Fri, Dec 13, 12:33. > > > Modified: > > head/share/man/man9/style.9 > > > > Modified: head/share/man/man9/style.9 > > > ============================================================================== > > --- head/share/man/man9/style.9 Fri Dec 13 22:04:13 2019 > (r355736) > > +++ head/share/man/man9/style.9 Fri Dec 13 22:32:05 2019 > (r355737) > > @@ -1,6 +1,5 @@ > > .\"- > > -.\" Copyright (c) 1995-2005 The FreeBSD Project > > -.\" All rights reserved. > > +.\" Copyright (c) 1995-2019 The FreeBSD Project > > .\" > > .\" Redistribution and use in source and binary forms, with or without > > .\" modification, are permitted provided that the following conditions > > @@ -26,7 +25,7 @@ > > .\" From: @(#)style 1.14 (Berkeley) 4/28/95 > > .\" $FreeBSD$ > > .\" > > -.Dd June 3, 2019 > > +.Dd December 13, 2019 > > .Dt STYLE 9 > > .Os > > .Sh NAME > > @@ -84,8 +83,32 @@ comments. > > Comments starting in columns other than the first are never > > considered license statements. > > Use the appropriate SPDX-License-Identifier line before the copyright. > > +If the copyright assertion contains the phrase > > +.Dq Li "All Rights Reserved" > > +that should be on the same line as the word > > +.Dq Li "Copyright" . > > +You should not insert a new copyright line between an old > > +copyright line and this phrase. > > +Instead, you should insert a new copyright phrase after > > +a pre-existing > > +.Dq Li "All Rights Reserved" > > +line. > > +When making changes, it is acceptable to fold an > > +.Dq Li "All Rights Reserved" > > +line with each of the > > +.Dq Li "Copyright" > > +lines. > > +For files that have the > > +.Dq Li "All Rights Reserved" > > +line on the same line(s) as the word > > +.Dq Li "Copyright" , > > +new copyright assertions should be added last. > > +New > > +.Dq Li "Copyright" > > +lines should only be added when making substantial changes to the file, > > +not for trivial changes. > > .Pp > > -After any copyright header, there is a blank line, and the > > +After any copyright and license comment, there is a blank line, and the > > .Li $\&FreeBSD$ > > for non C/C++ language source files. > > Version control system ID tags should only exist once in a file > > > > -- > Rod Grimes > rgrimes@freebsd.org >