From owner-freebsd-arm@FreeBSD.ORG Fri Oct 10 17:13:22 2008 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37FC01065691 for ; Fri, 10 Oct 2008 17:13:22 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id E88E38FC32 for ; Fri, 10 Oct 2008 17:13:21 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m9AHAF0V077064; Fri, 10 Oct 2008 11:10:15 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 10 Oct 2008 11:11:20 -0600 (MDT) Message-Id: <20081010.111120.-1704377131.imp@bsdimp.com> To: xcllnt@mac.com From: "M. Warner Losh" In-Reply-To: References: <48DA31B3.5040906@semihalf.com> <48EF2481.2010307@semihalf.com> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-arm@freebsd.org Subject: Re: FreeBSD/arm support for Marvell chips -- please review X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Oct 2008 17:13:22 -0000 In message: Marcel Moolenaar writes: : : On Oct 10, 2008, at 2:46 AM, Rafal Jaworowski wrote: : : > Rafal Jaworowski wrote: : >> All, : >> With the recent series of submits in P4's arm-devel branch, I have : >> completed : >> import of FreeBSD/arm support for three families of Marvell : >> integrated : >> systems-on-chip built on ARMv5TE-compliant core. Orion support has : >> been around : >> for a while already, and recently added were extensions for : >> Kirkwood and : >> Discovery support, new drivers for integrated peripherals and other : >> improvements. : >> : >> I'd like to merge this with SVN within the coming weeks, so would : >> like to ask : >> everyone to review the code and let me know about any comments or : >> notes: : > : > I haven't received much feedback, are people still reviewing this? : : Just my $0.02: : : I personally don't like the deep nesting of directories, : but other than that: it looks and works great. I don't have a problem with the deep nesting of these directories. It seems a good balance. The mips32/ extra layer in the mips port, however, was just gratuitous. The xscale stuff isn't too bad either, but sometimes feels a little deep. Each time I've looked at it, however, I can't come up with anything better... : I have some tweaks to add later. For example: : FPA support on little endian ARM (FPA has the words in : big-endian, irrespective of the byte order). We have : 4 places where we define the IEEE representation and : where we need to account for this. FPA? : FYI, : : -- : Marcel Moolenaar : xcllnt@mac.com : : : : _______________________________________________ : freebsd-arm@freebsd.org mailing list : http://lists.freebsd.org/mailman/listinfo/freebsd-arm : To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org" : :