From owner-svn-src-all@freebsd.org Mon Nov 30 09:28:07 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8B1B94751A3; Mon, 30 Nov 2020 09:28:07 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cl0Jl0KZmz4pfn; Mon, 30 Nov 2020 09:28:06 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1606728478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XWo0x+qrgHukIjvH2TOEmBnKh0wTjGt/LQaWgKc4OSI=; b=XAf13VjQWIBi8Lf82OZHVAQvnegRiczrYEhB4Oyim8cJskY9kbTCXPcmPKVeee0eR4/+e1 BUv+M8Pbwp5Y/KePV+j6EGhFR45HIw5vyiW+Zu0BFqQEPqIJ+f1IMaJeyWrYXjWHTBM/wD zpO+GuxSN5TQQ38jopXXzXq5GzjtEAo= Received: from amy.home (lfbn-idf2-1-288-247.w82-123.abo.wanadoo.fr [82.123.126.247]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 49e063c6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 30 Nov 2020 09:27:58 +0000 (UTC) Date: Mon, 30 Nov 2020 10:27:58 +0100 From: Emmanuel Vadot To: "Bjoern A. Zeeb" Cc: "Matt Macy" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368163 - in head: sbin/ifconfig sys/dev/if_wg sys/dev/if_wg/include sys/dev/if_wg/include/crypto sys/dev/if_wg/include/sys sys/dev/if_wg/include/zinc sys/dev/if_wg/module sys/dev/if_wg... Message-Id: <20201130102758.c600f147a801933bb66529c7@bidouilliste.com> In-Reply-To: References: <202011291938.0ATJc4Z3081193@repo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Cl0Jl0KZmz4pfn X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2020 09:28:07 -0000 On Mon, 30 Nov 2020 01:13:12 +0000 "Bjoern A. Zeeb" wrote: > On 29 Nov 2020, at 19:38, Matt Macy wrote: > > > Author: mmacy > > Date: Sun Nov 29 19:38:03 2020 > > New Revision: 368163 > > URL: https://svnweb.freebsd.org/changeset/base/368163 > > > > Log: > > Import kernel WireGuard support > > > > Data path largely shared with the OpenBSD implementation by > > Matt Dunwoodie > > > > Reviewed by: grehan@freebsd.org > > MFC after: 1 month > > Sponsored by: Rubicon LLC, (Netgate) > > Differential Revision: https://reviews.freebsd.org/D26137 > > > > Added: > > head/sbin/ifconfig/ifwg.c (contents, props changed) > > head/sys/dev/if_wg/ > > head/sys/dev/if_wg/include/ > > head/sys/dev/if_wg/include/crypto/blake2s.h (contents, props > > changed) > > head/sys/dev/if_wg/include/crypto/curve25519.h (contents, props > > changed) > > head/sys/dev/if_wg/include/crypto/zinc.h (contents, props changed) > > head/sys/dev/if_wg/include/sys/ > > head/sys/dev/if_wg/include/sys/if_wg_session.h (contents, props > > changed) > > head/sys/dev/if_wg/include/sys/if_wg_session_vars.h (contents, > > props changed) > > head/sys/dev/if_wg/include/sys/simd-x86_64.h (contents, props > > changed) > > head/sys/dev/if_wg/include/sys/support.h (contents, props changed) > > head/sys/dev/if_wg/include/sys/wg_cookie.h (contents, props > > changed) > > head/sys/dev/if_wg/include/sys/wg_module.h (contents, props > > changed) > > head/sys/dev/if_wg/include/sys/wg_noise.h (contents, props > > changed) > > head/sys/dev/if_wg/include/zinc/blake2s.h (contents, props > > changed) > > head/sys/dev/if_wg/include/zinc/chacha20.h (contents, props > > changed) > > head/sys/dev/if_wg/include/zinc/chacha20poly1305.h (contents, > > props changed) > > head/sys/dev/if_wg/include/zinc/curve25519.h (contents, props > > changed) > > head/sys/dev/if_wg/include/zinc/poly1305.h (contents, props > > changed) > > head/sys/dev/if_wg/module/ > > head/sys/dev/if_wg/module/blake2s.c (contents, props changed) > > head/sys/dev/if_wg/module/blake2s.h (contents, props changed) > > head/sys/dev/if_wg/module/chacha20-x86_64.S (contents, props > > changed) > > head/sys/dev/if_wg/module/crypto/zinc/chacha20/chacha20-arm-glue.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/chacha20/chacha20-arm.pl > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/chacha20/chacha20-arm64.pl > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/chacha20/chacha20-mips-glue.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/chacha20/chacha20-mips.S > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/chacha20/chacha20-unrolled-arm.S > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/chacha20/chacha20-x86_64-glue.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/chacha20/chacha20-x86_64.pl > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/chacha20/chacha20.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/chacha20poly1305.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/poly1305/poly1305-arm-glue.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/poly1305/poly1305-arm.pl > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/poly1305/poly1305-arm64.pl > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/poly1305/poly1305-donna32.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/poly1305/poly1305-donna64.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/poly1305/poly1305-mips-glue.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/poly1305/poly1305-mips.S > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/poly1305/poly1305-mips64.pl > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/poly1305/poly1305-x86_64-glue.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/poly1305/poly1305-x86_64.pl > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/poly1305/poly1305.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/selftest/blake2s.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/selftest/chacha20.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/selftest/chacha20poly1305.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/selftest/curve25519.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/selftest/poly1305.c > > (contents, props changed) > > head/sys/dev/if_wg/module/crypto/zinc/selftest/run.h (contents, > > props changed) > > head/sys/dev/if_wg/module/curve25519.c (contents, props changed) > > head/sys/dev/if_wg/module/if_wg_session.c (contents, props > > changed) > > head/sys/dev/if_wg/module/module.c (contents, props changed) > > head/sys/dev/if_wg/module/poly1305-x86_64.S (contents, props > > changed) > > head/sys/dev/if_wg/module/wg_cookie.c (contents, props changed) > > head/sys/dev/if_wg/module/wg_noise.c (contents, props changed) > > head/sys/modules/if_wg/ > > head/sys/modules/if_wg/Makefile (contents, props changed) > > Directory Properties: > > head/sys/dev/if_wg/include/crypto/ (props changed) > > head/sys/dev/if_wg/include/zinc/ (props changed) > > head/sys/dev/if_wg/module/crypto/ (props changed) > > head/sys/dev/if_wg/module/crypto/zinc/ (props changed) > > head/sys/dev/if_wg/module/crypto/zinc/chacha20/ (props changed) > > head/sys/dev/if_wg/module/crypto/zinc/poly1305/ (props changed) > > head/sys/dev/if_wg/module/crypto/zinc/selftest/ (props changed) > > > Looking at sys/dev/if_wg/include/sys/support.h I wonder why zinc was not > done as linuxkpi code? Could it be? > > > /bz Adding a dependancy on linuxkpi for just a few compat funcs looks overkill, also having it done that way means that mallocs are typed with M_WG instead of the global M_LINUXKPI so it's better to track leaks, if any. -- Emmanuel Vadot