From owner-cvs-ports@FreeBSD.ORG Thu Mar 25 13:39:36 2010 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C7C9106564A; Thu, 25 Mar 2010 13:39:36 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id E0E898FC27; Thu, 25 Mar 2010 13:39:35 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.3/8.14.3/ALCHEMY.FRANKEN.DE) with ESMTP id o2PDdYLY040241; Thu, 25 Mar 2010 14:39:34 +0100 (CET) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.3/8.14.3/Submit) id o2PDdY0g040240; Thu, 25 Mar 2010 14:39:34 +0100 (CET) (envelope-from marius) Date: Thu, 25 Mar 2010 14:39:34 +0100 From: Marius Strobl To: Gary Jennejohn Message-ID: <20100325133934.GE20888@alchemy.franken.de> References: <201003220505.o2M556oW060661@repoman.freebsd.org> <20100323215506.GA19561@alchemy.franken.de> <1269514777.8175.3.camel@balrog.2hip.net> <20100325125012.GD20888@alchemy.franken.de> <20100325142237.1ceae7db@ernst.jennejohn.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100325142237.1ceae7db@ernst.jennejohn.org> User-Agent: Mutt/1.4.2.3i Cc: Robert Noland , Mark Linimon , nork@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org, cvs-ports@freebsd.org Subject: Re: cvs commit: ports/graphics/dri Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Mar 2010 13:39:36 -0000 On Thu, Mar 25, 2010 at 02:22:37PM +0100, Gary Jennejohn wrote: > On Thu, 25 Mar 2010 13:50:12 +0100 > Marius Strobl wrote: > > > On Thu, Mar 25, 2010 at 05:59:37AM -0500, Robert Noland wrote: > > > On Tue, 2010-03-23 at 16:55, Marius Strobl wrote: > > > > On Mon, Mar 22, 2010 at 05:05:06AM +0000, Mark Linimon wrote: > > > > > linimon 2010-03-22 05:05:06 UTC > > > > > > > > > > FreeBSD ports repository > > > > > > > > > > Modified files: > > > > > graphics/dri Makefile > > > > > Log: > > > > > Mark as broken on ia64 and sparc64: fails to install. > > > > > > > > > > Hat: portmgr > > > > > > > > > > > > > The following patch fixes the powerpc [sic] and sparc64 build of the > > > > default Mesa3D 7.4.4 after the 7.6.1 integration: > > > > http://people.freebsd.org/~marius/mesa3d_7.6.1_unbreak.diff > > > > Is it okay to commit? > > > > > > Looks good to me, this will save me some work now that I have both a > > > powerpc and sparc64 boxes to play with. In looking at mesa git, I think > > > I'll be making a few changes shortly... > > > > > > > So could someone please either approve or commit it (I have only > > a src bit). > > > > Looks to me like Robert already approved it. I think interpreting his comment as an "Approved by:" rather than a "Reviewed by:" would be stretching it a bit too much. > > Having only a src commit bit shouldn't prevent your making a ports commit. > I've seen ports committers make src commits. > Sure, but you always need an explicit approval for committing to a repository you don't have a bit for (at least so I've been told). Marius