From owner-freebsd-current@FreeBSD.ORG  Wed Nov  2 00:24:46 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 31D7216A41F
	for <current@freebsd.org>; Wed,  2 Nov 2005 00:24:46 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9326A43D46
	for <current@freebsd.org>; Wed,  2 Nov 2005 00:24:45 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id jA20OMJC044784;
	Tue, 1 Nov 2005 17:24:22 -0700 (MST)
	(envelope-from scottl@samsco.org)
Message-ID: <43680737.6080108@samsco.org>
Date: Tue, 01 Nov 2005 17:24:23 -0700
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050615
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Doug Ambrisko <ambrisko@ambrisko.com>
References: <200511020011.jA20B0S4039654@ambrisko.com>
In-Reply-To: <200511020011.jA20B0S4039654@ambrisko.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org
Cc: current@freebsd.org
Subject: Re: Rocket Port update patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Nov 2005 00:24:46 -0000

Doug Ambrisko wrote:
> I've brought in the changes to the driver from the Comtrol web site.
> This greatly improves the RocketPort HW support for those devices.
> The changes are at:
> 	http://www.ambrisko.com/doug/rp_current.patch
> 
> I'd like to commit it so things just work out of the box.  I tried to
> maintain all the various FreeBSD & Comtrol changes.
> 
> It works here on my previously unsupported card.
> 
> Thanks,
> 
> Doug A.

One thing stands out on the brief skim.  Why on earth does the code need 
to keep a global count of the number of adapters, and why does it bail 
if there are more than 4 adapters?

Scott