From owner-cvs-sbin  Sun Oct 13 14:51:13 1996
Return-Path: owner-cvs-sbin
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id OAA07739
          for cvs-sbin-outgoing; Sun, 13 Oct 1996 14:51:13 -0700 (PDT)
Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id OAA07637;
          Sun, 13 Oct 1996 14:49:33 -0700 (PDT)
Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <14736(1)>; Sun, 13 Oct 1996 14:48:57 PDT
Received: from localhost by crevenia.parc.xerox.com with SMTP id <177477>; Sun, 13 Oct 1996 14:48:50 -0700
To: Joerg Wunsch <joerg@freefall.freebsd.org>
cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
        cvs-sbin@freefall.freebsd.org
Subject: Re: cvs commit: src/sbin/savecore savecore.c 
In-reply-to: Your message of "Sun, 13 Oct 96 13:55:50 PDT."
             <199610132055.NAA05442@freefall.freebsd.org> 
Date: Sun, 13 Oct 1996 14:48:37 PDT
From: Bill Fenner <fenner@parc.xerox.com>
Message-Id: <96Oct13.144850pdt.177477@crevenia.parc.xerox.com>
Sender: owner-cvs-sbin@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

In message <199610132055.NAA05442@freefall.freebsd.org> you write:
>  However, he missed the part to compute the kernelsize in kilobytes,
>  so the minfree consideration was now overcautious.  (I've also
>  changed the return type of dump_size() to void since int was useless.)

Sorry, I thought I had made sure that everything was in K.  Unless I
missed something, the patch in the PR causes minfree to be specified in
bytes, which is not what the man page says.

In fact, if I re-read my patch, it looks like spacefree and totfree are
kept in units of K-bytes, kernelsize and dumpsize are kept in units of
bytes but needed = (dumpsize + kernelsize) / 1024, so needed is in units
of K-bytes, and minfree is specified in the file as being specified in
K-bytes.  What am I missing?

  Bill