Date: Sun, 13 Oct 1996 14:48:37 PDT From: Bill Fenner <fenner@parc.xerox.com> To: Joerg Wunsch <joerg@freefall.freebsd.org> Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/savecore savecore.c Message-ID: <96Oct13.144850pdt.177477@crevenia.parc.xerox.com> In-Reply-To: Your message of "Sun, 13 Oct 96 13:55:50 PDT." <199610132055.NAA05442@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199610132055.NAA05442@freefall.freebsd.org> you write: > However, he missed the part to compute the kernelsize in kilobytes, > so the minfree consideration was now overcautious. (I've also > changed the return type of dump_size() to void since int was useless.) Sorry, I thought I had made sure that everything was in K. Unless I missed something, the patch in the PR causes minfree to be specified in bytes, which is not what the man page says. In fact, if I re-read my patch, it looks like spacefree and totfree are kept in units of K-bytes, kernelsize and dumpsize are kept in units of bytes but needed = (dumpsize + kernelsize) / 1024, so needed is in units of K-bytes, and minfree is specified in the file as being specified in K-bytes. What am I missing? Bill
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?96Oct13.144850pdt.177477>