From owner-freebsd-fs@FreeBSD.ORG Sun Jul 27 21:24:28 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 555471065676 for ; Sun, 27 Jul 2008 21:24:28 +0000 (UTC) (envelope-from freebsd-fs@m.gmane.org) Received: from ciao.gmane.org (main.gmane.org [80.91.229.2]) by mx1.freebsd.org (Postfix) with ESMTP id D99BC8FC15 for ; Sun, 27 Jul 2008 21:24:27 +0000 (UTC) (envelope-from freebsd-fs@m.gmane.org) Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KNDj7-0007Mg-Ji for freebsd-fs@freebsd.org; Sun, 27 Jul 2008 21:24:25 +0000 Received: from 78-0-85-142.adsl.net.t-com.hr ([78.0.85.142]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 27 Jul 2008 21:24:25 +0000 Received: from ivoras by 78-0-85-142.adsl.net.t-com.hr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 27 Jul 2008 21:24:25 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: freebsd-fs@freebsd.org From: Ivan Voras Date: Sun, 27 Jul 2008 23:24:09 +0200 Lines: 121 Message-ID: References: <20080727125413.GG1345@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig44B0235121D6BCA8F9F89B83" X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 78-0-85-142.adsl.net.t-com.hr User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) In-Reply-To: <20080727125413.GG1345@garage.freebsd.pl> X-Enigmail-Version: 0.95.6 Sender: news Cc: freebsd-current@freebsd.org Subject: Re: ZFS patches. X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jul 2008 21:24:28 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig44B0235121D6BCA8F9F89B83 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Pawel Jakub Dawidek wrote: > Hi. >=20 > http://people.freebsd.org/~pjd/patches/zfs_20080727.patch.bz2 >=20 > The patch above contains the most recent ZFS version that could be foun= d > in OpenSolaris as of today. Apart for large amount of new functionality= , > I belive there are many stability (and also performance) improvements > compared to the version from the base system. >=20 > Check out OpenSolaris website to find out the differences between base > system version and patch version. >=20 > Please test, test, test. If I get enough positive feedback, I may be > able to squeeze it into 7.1-RELEASE, but this might be hard. I'm trying to test it, and my build fails at an unusual place - dtrace.=20 I've verified that a clean cvsup tree compiles the dtrace modules, and=20 it fails with the same tree patched with the above patch. Any ideas? The exact command for applying the patch was: wbench:/usr/src# patch -p0 < ~ivoras/zfs_20080727.patch The failure is: =3D=3D=3D> dtmalloc (all) Warning: Object directory not changed from original=20 /usr/src/sys/modules/dtrace/dtmalloc cc -O2 -fno-strict-aliasing -pipe -Werror -D_KERNEL -DKLD_MODULE=20 -std=3Dc99 -nostdinc=20 -I/usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/compat/opensolaris=20 -I/usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/contrib/opensolaris/= uts/common=20 -I/usr/src/sys/modules/dtrace/dtmalloc/../../.. -I. -I@ -I@/contrib/altq = -finline-limit=3D8000 --param inline-unit-growth=3D100 --param=20 large-function-growth=3D1000 -fno-common -mno-align-long-strings=20 -mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2=20 -mno-sse3 -ffreestanding -fstack-protector -Wall -Wredundant-decls=20 -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes=20 -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign=20 -fformat-extensions -Wno-unknown-pragmas -c=20 /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/dev/dtmalloc/dtmalloc.= c In file included from=20 /usr/src/sys/modules/dtrace/dtmalloc/../../../sys/vnode.h:541, from=20 /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/contrib/opensolaris/ut= s/common/sys/vnode.h:44, from=20 /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/compat/opensolaris/sys= /vnode.h:43, from=20 /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/compat/opensolaris/sys= /kobj.h:41, from=20 /usr/src/sys/modules/dtrace/dtmalloc/../../../sys/linker.h:35, from=20 /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/compat/opensolaris/sys= /modctl.h:34, from=20 /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/contrib/opensolaris/ut= s/common/sys/dtrace.h:50, from=20 /usr/src/sys/modules/dtrace/dtmalloc/../../../cddl/dev/dtmalloc/dtmalloc.= c:35: =2E/vnode_if.h:1161: error: expected specifier-qualifier-list before=20 'acl_type_t' =2E/vnode_if.h:1174: error: expected declaration specifiers or '...'=20 before 'acl_type_t' cc1: warnings being treated as errors =2E/vnode_if.h:1177: warning: 'struct acl' declared inside parameter list= =2E/vnode_if.h:1177: warning: its scope is only this definition or=20 declaration, which is probably not what you want =2E/vnode_if.h: In function 'VOP_GETACL': =2E/vnode_if.h:1183: error: 'struct vop_getacl_args' has no member named = 'a_type' =2E/vnode_if.h:1183: error: 'type' undeclared (first use in this function= ) This is -current from a few minutes ago, i386, GENERIC kernel with=20 INVARIANTS and WITNESS (and their supporting options) removed. Excerpt from vnode_if.h: 1158 struct vop_getacl_args { 1159 struct vop_generic_args a_gen; 1160 struct vnode *a_vp; 1161 acl_type_t a_type; 1162 struct acl *a_aclp; 1163 struct ucred *a_cred; 1164 struct thread *a_td; 1165 }; --------------enig44B0235121D6BCA8F9F89B83 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIjOd/ldnAQVacBcgRAo9/AJ9G8del2ewKm3hSqaCWbiLV9hTgbwCfbJ2O P2+J8zAGDXO3WGan0nKFdXs= =mE0o -----END PGP SIGNATURE----- --------------enig44B0235121D6BCA8F9F89B83--