From owner-freebsd-bugs@freebsd.org Sat Jan 23 22:33:03 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 805CAA8D8D2 for ; Sat, 23 Jan 2016 22:33:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 563021C19 for ; Sat, 23 Jan 2016 22:33:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u0NMX31o014450 for ; Sat, 23 Jan 2016 22:33:03 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 206544] sendit "KPI" (in reality sendmsg(2); maybe sendto(2)) will fail with EINVAL if there's a mp->msg_control is not NULL and mp->msg_controllen is < sizeof(struct cmsghdr); is not documented in send(2) Date: Sat, 23 Jan 2016 22:33:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 9.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ngie@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jan 2016 22:33:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206544 Bug ID: 206544 Summary: sendit "KPI" (in reality sendmsg(2); maybe sendto(2)) will fail with EINVAL if there's a mp->msg_control is not NULL and mp->msg_controllen is < sizeof(struct cmsghdr); is not documented in send(2) Product: Base System Version: 9.3-STABLE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: ngie@FreeBSD.org 769 static int 770 sendit(td, s, mp, flags) 771 struct thread *td; 772 int s; 773 struct msghdr *mp; 774 int flags; 775 { ... 796 if (mp->msg_control) { 797 if (mp->msg_controllen < sizeof(struct cmsghdr) 798 #ifdef COMPAT_OLDSOCK 799 && mp->msg_flags !=3D MSG_COMPAT 800 #endif 801 ) { 802 error =3D EINVAL; 803 goto bad; 804 } The behavior on line 802 is not documented anywhere in send(2). It was driv= ing me nuts trying to figure out what was going on in tools/regression/unix_cmsg:t_cmsg_len because the test fails on amd64 becau= se that conditional is tripped -_-... --=20 You are receiving this mail because: You are the assignee for the bug.=