From owner-freebsd-gecko@freebsd.org Mon Mar 18 08:15:58 2019 Return-Path: Delivered-To: freebsd-gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF16B15354A0 for ; Mon, 18 Mar 2019 08:15:58 +0000 (UTC) (envelope-from grahamperrin@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id CB0BF75C8C for ; Mon, 18 Mar 2019 08:15:57 +0000 (UTC) (envelope-from grahamperrin@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 88614153549F; Mon, 18 Mar 2019 08:15:57 +0000 (UTC) Delivered-To: gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4D74E153549E for ; Mon, 18 Mar 2019 08:15:57 +0000 (UTC) (envelope-from grahamperrin@gmail.com) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C274975C88; Mon, 18 Mar 2019 08:15:56 +0000 (UTC) (envelope-from grahamperrin@gmail.com) Received: by mail-wm1-x341.google.com with SMTP id z11so3437434wmi.0; Mon, 18 Mar 2019 01:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=yqfY2bZ//54cB8Yo7WgI/qoyYqOKP4F3NUMm7A2pDtA=; b=fL3+XsMzySOUEsaluiyl+81fK46eVVjTrxpdvurP/wn7wuar8a4P/sPh3olx9Uk3rn 7+KVlHdS9AoHkbR1wbUUDRHIIK2ZY6jStmDm15ZFZ5MDG0MCqTDozxnjUq2R0z/QM+7P XSZa3pc2hjFMvdntzHY68QnZmENmZcTLHMa2uHJYzZPGOV6A/CNUx5/001+m30ntt6V+ 4sZImTvQZBdQMOgKa2veOA5xKbNfTDZPyE1FBOgRwbsy9jAOyFvayUKc7zaGkQ9BDBzJ X3yfn/wuo6FWQMswdyEiGllZEAMLcwY9Qe9CjBI2Obcnh6H05YVKOA2L0iWhR1Jd4oD1 jVkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=yqfY2bZ//54cB8Yo7WgI/qoyYqOKP4F3NUMm7A2pDtA=; b=A5WTouuhWx3YLtSK0dvp1NaShXBY9DFp4OxEYB7YyHL3VeI3zKOnPuVFsrF//cjGbP MrLt4Nr4klPLVuZR/Xn4FTRpUp+hB2eXL2wIkfTwVtcUmbU2zRdipUMUDZgp3ynqhJ5W Dfuu7p9pt6SAY+Q4N2o5y8fdAxXnaB6bNCECIIIqvm474hiaNgqXwMEbu7n0jb8H/Lk8 uMbKGKFu2xM/8b9KJwXqD3xH66Kqw2O+JeJE6rGoM+QUA9zmcU/omayMWZwb1JUlMIK4 E/yJvTm2hVn4CoUHHLOOZmgbJ+SCn4V5A1xHRFa5cSRiPMaN0xshW7XcHnamRPsr5NMC utyQ== X-Gm-Message-State: APjAAAWqNebLBW0tX2IG+DBoDCqtt30STyze8xJuPsm+LmywxB6vVP1i qfJN38fjsQLlL/MTTDrXvRBD5sIfAGY= X-Google-Smtp-Source: APXvYqzCWYiFDybsWrUEAO6CaP5Ne66agysbYMCDqq8qSEiNctM8lgwSHJ6S48IPS5mlIOvLf+x7KQ== X-Received: by 2002:a1c:9ed5:: with SMTP id h204mr10167934wme.140.1552896955018; Mon, 18 Mar 2019 01:15:55 -0700 (PDT) Received: from [192.168.1.7] (79-66-139-63.dynamic.dsl.as9105.com. [79.66.139.63]) by smtp.gmail.com with ESMTPSA id t62sm11924266wmf.15.2019.03.18.01.15.53 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 01:15:53 -0700 (PDT) Subject: Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro To: Charlie Li , Jan Beich Cc: gecko@freebsd.org References: <496db844-cb0b-1b53-b498-beec9324b9c0@gmail.com> <1a8a2cd4-fce2-5dca-ec4a-a417d783f56a@vishwin.info> From: Graham Perrin Message-ID: <340c1855-c3c7-af5d-a375-9e95bd72864f@gmail.com> Date: Mon, 18 Mar 2019 08:15:52 +0000 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <1a8a2cd4-fce2-5dca-ec4a-a417d783f56a@vishwin.info> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: C274975C88 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[freebsd]; REPLY(-4.00)[] X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Mar 2019 08:15:59 -0000 On 17/03/2019 19:54, Charlie Li wrote: > On 17/03/2019 12:25, Jan Beich wrote: > >> … >> >> Looks like a regression from Rust 1.33 update. >> >> Either remove missing_docs from #![deny(...)] lines (or lines themselves) >> for each one that triggers error (no need to bother with unused ones) or >> add MOZ_OPTIONS+=--disable-stylo to Makefile.local. >> >> … > > I simply followed the tip given in Mozilla bug 1521249 (remove > `#![deny(missing_docs)]`), and have been running with it since we > updated our lang/rust to 1.33: > https://bugzilla.mozilla.org/show_bug.cgi?id=1521249#c36 > > … Thank you both. In my fork: – at a glance, does that look OK? I'm unsure about , should that line be left as was?  #[deny(missing_docs)] (No exclamation mark.)