From owner-svn-src-head@FreeBSD.ORG Tue Jun 9 13:56:12 2015 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8B80CE7A; Tue, 9 Jun 2015 13:56:12 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 3DF551630; Tue, 9 Jun 2015 13:56:10 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA25767; Tue, 09 Jun 2015 16:56:08 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Z2K0e-0009iG-9m; Tue, 09 Jun 2015 16:56:08 +0300 Message-ID: <5576F054.2010207@FreeBSD.org> Date: Tue, 09 Jun 2015 16:55:32 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jan Beich CC: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r284107 - head/sys/cddl/compat/opensolaris/sys References: <201506070854.t578sPdR012092@svn.freebsd.org> <5576CA36.8060403@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2015 13:56:12 -0000 On 09/06/2015 16:41, Jan Beich wrote: > Andriy Gapon writes: > >> On 09/06/2015 13:31, Jan Beich wrote: >> >>> Andriy Gapon writes: >>> >>>> Author: avg Date: Sun Jun 7 08:54:25 2015 New Revision: 284107 URL: >>>> https://svnweb.freebsd.org/changeset/base/284107 >>>> >>>> Log: compat nvpair.h: make sure that the names are mangled only for >>>> kernel >>>> >>>> Currently there is no good reason to mangle the userland API. The change >>>> was introduced in eac1d566b46edef765754203bef22c75c1699966, r279437. >>>> Also see https://reviews.freebsd.org/D1881. >>> >>> Can you bump __FreeBSD_version? At least sysutils/geomWatch requires it. >>> >>> https://svnweb.freebsd.org/changeset/ports/388906 >> >> There should have been a bug report and an src fix instead of (parts of) >> https://svnweb.freebsd.org/ports?view=revision&revision=386870 > > Good point. However, opensolaris libs have unclear ABI guarantees. Indeed. > Their > API is not exposed but the libs aren't marked PRIVATELIB. Some symbols > are removed on updates *without* corresponding SHLIB_MAJOR bumps. > libnvpair is mostly unchanged between 8.4R and 11.0C, though. I think that we should treat ABI breakages for ZFS-related libs same as for other libs. Symbol versioning could be a hassle, but at least a library version bump is warranted. > # shouldn't be possible without libzfs.so.2 in libmap.conf > /poudriere/jails/84amd64/sbin/zfs: Undefined symbol "zpool_set_history_str" > >> I wonder why the libnvpair ABI breakage was silently accepted but the ABI fix >> requires some special magic... > > I'll probably back out ports@386870 and ports@388906 after a while. > libnvpair with bogus ABI existed on 11.0C for 3 months, enough to end up > in the binary snapshots a few times. In either case please let me know if the __FreeBSD_version bump would be of help to you, I certainly can do it. -- Andriy Gapon