From owner-cvs-ports@FreeBSD.ORG  Mon Apr 24 22:31:58 2006
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
X-Original-To: cvs-ports@FreeBSD.ORG
Delivered-To: cvs-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B8F5516A46B;
	Mon, 24 Apr 2006 22:31:58 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C782F43D60;
	Mon, 24 Apr 2006 22:31:57 +0000 (GMT)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.13.6/8.13.6) with ESMTP id k3OMVqSo024097;
	Tue, 25 Apr 2006 02:31:52 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
Received: (from ache@localhost)
	by nagual.pp.ru (8.13.6/8.13.6/Submit) id k3OMVqJR024096;
	Tue, 25 Apr 2006 02:31:52 +0400 (MSD) (envelope-from ache)
Date: Tue, 25 Apr 2006 02:31:51 +0400
From: Andrey Chernov <ache@FreeBSD.ORG>
To: Jeremy Chadwick <freebsd@jdc.parodius.com>
Message-ID: <20060424223151.GA23584@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@freebsd.org>,
	Jeremy Chadwick <freebsd@jdc.parodius.com>,
	Kris Kennaway <kris@obsecurity.org>, ports-committers@FreeBSD.ORG,
	cvs-ports@FreeBSD.ORG, cvs-all@FreeBSD.ORG
References: <200604241404.k3OE49eJ074318@repoman.freebsd.org>
	<20060424180431.GA13567@xor.obsecurity.org>
	<20060424210548.GA80839@pentarou.parodius.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060424210548.GA80839@pentarou.parodius.com>
User-Agent: Mutt/1.5.11
Cc: cvs-ports@FreeBSD.ORG, ports-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG,
	Kris Kennaway <kris@obsecurity.org>
Subject: Re: cvs commit: ports/graphics/png/files patch-aa
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Apr 2006 22:31:58 -0000

On Mon, Apr 24, 2006 at 02:05:48PM -0700, Jeremy Chadwick wrote:
> On Mon, Apr 24, 2006 at 02:04:31PM -0400, Kris Kennaway wrote:
> > On Mon, Apr 24, 2006 at 02:04:09PM +0000, Andrey A. Chernov wrote:
> > > ache        2006-04-24 14:04:09 UTC
> > > 
> > >   FreeBSD ports repository
> > > 
> > >   Modified files:
> > >     graphics/png/files   patch-aa 
> > >   Log:
> > >   Use NO_OBJ NO_PROFILE instead of obsoleted their variants
> > >   
> > >   PR:     96244
> > >   Submitted by:   Jeremy Chadwick <freebsd@jdc.parodius.com>
> > 
> > Are you sure this works on old FreeBSD branches?
> 
> .if ${OSVERSION} < 500000
> MAKE_ARGS+=	-DNOPROFILE -DNOOBJ
> .else
> MAKE_ARGS+=	-DNO_PROFILE -DNO_OBJ
> .endif

I don't think it deserve such complex tweaking: in worst possible case 4.x 
users will additionaly build profiled library too, and since libpng is 
small, it will not produce much difference.

-- 
http://ache.pp.ru/