From owner-freebsd-current@FreeBSD.ORG Sat Apr 5 03:36:07 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3F5E3CA1 for ; Sat, 5 Apr 2014 03:36:07 +0000 (UTC) Received: from mail-lb0-f172.google.com (mail-lb0-f172.google.com [209.85.217.172]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B20E6753 for ; Sat, 5 Apr 2014 03:36:06 +0000 (UTC) Received: by mail-lb0-f172.google.com with SMTP id c11so3084292lbj.17 for ; Fri, 04 Apr 2014 20:36:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=+yAnB0oJ90ru75NAKg+YmehNE4frAy4vkMxP+kBliEU=; b=dqQNna5tidE7UypUOl+3HuMDdBkpztnkkF/m6DdBKTwstOQSnYlaECWQEKGvOWlY83 KkewiNj3SoM2DUV68DxSGfYkPeukk5DWVh8tJ+PZ4UXJbWAg7SNmOv2rlqeGXMywVvzB fd+IWbz2CNjJ01YfArhvmEhSLoZnl9fv95wiibFx8E49SukNFK4XPV3xuF0b6ArNXqJe 0GecXlBsGr8iDfvrq8gQV9bqBezk3XBpNnS4fiW7D4LcP/VlzCE5Q7WLmq6VQT4KizNE 0mOm9ZoqZvYdrH0GbJi3IHj6qBvz0SnsxfkqndqTHmkifh9gRVOFkMJZUTsjmm2/bfJ3 JYVA== X-Gm-Message-State: ALoCoQk/M9HrymS5K6DUb5FxgK/lgkGJGmaeQSvQkAWkY4VUXDKPURnH3rjPFqm/m9axb5V5eG+E X-Received: by 10.152.22.37 with SMTP id a5mr11062958laf.4.1396668964122; Fri, 04 Apr 2014 20:36:04 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by mx.google.com with ESMTPSA id wm1sm9635243lac.14.2014.04.04.20.36.02 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 04 Apr 2014 20:36:02 -0700 (PDT) Message-ID: <533F7A14.7060403@freebsd.org> Date: Sat, 05 Apr 2014 07:35:48 +0400 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: sbruno@freebsd.org Subject: Re: login.conf --> UTF-8 References: <1396457629.2280.2.camel@powernoodle.corp.yahoo.com> <20140402171546.GL44326@FreeBSD.org> <533C8269.7040305@freebsd.org> <20140404124634.GC44326@glebius.int.ru> <533F5DF5.9020803@freebsd.org> <1396665553.2415.0.camel@powernoodle.corp.yahoo.com> In-Reply-To: <1396665553.2415.0.camel@powernoodle.corp.yahoo.com> X-Enigmail-Version: 1.7a1pre Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cpMjnvqgx8hIIMiisNcgSOWqhf4qoBnWx" Cc: Gleb Smirnoff , i18n@freebsd.org, "freebsd-current@freebsd.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Apr 2014 03:36:07 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cpMjnvqgx8hIIMiisNcgSOWqhf4qoBnWx Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable On 05.04.2014 6:39, Sean Bruno wrote: > On Sat, 2014-04-05 at 05:35 +0400, Andrey Chernov wrote: >> On 04.04.2014 16:46, Gleb Smirnoff wrote: >>> On Thu, Apr 03, 2014 at 01:34:33AM +0400, Andrey Chernov wrote: >>> A> On 02.04.2014 21:15, Gleb Smirnoff wrote: >>> A> > S> + :lang=3Den_US.UTF-8:\ >>> A> > S> + :charset=3DUTF-8: >>> A> >=20 >>> A> > And I'd like to do same change for the 'russian' login class >>> A> > in /etc/login.conf. >>> A>=20 >>> A> Please everybody remember that we don't have UTF-8 collation >>> A> implemented, just fallback to bytecode comparison. >>> >>> Any objections on checking in FreeBSD-compatible[1] UTF-8 collation >>> implementation from Alex Tutubalin? >>> >>> http://blog.lexa.ru/2008/03/03/freebsd_utf8_russian_collate_vtoraja_p= opitka.html >>> >> >> Even his "version 2" have my objections. I already reply Alex about th= is >> in 2008. In short: >> 1) It is error there: almost all single chars above ASCII should be >> "chains", i.t. two bytes minimum, since there almost no intersections >> with ISO8859-1 as UTF-8 subset. >> 2) The table itself is very incomplete, f.e. not covering either whole= >> KOI8-R, nor ISO8859-5, nor CP866. It is made from CP1251 with all its >> restrictions. So, switching from f.e. KOI8-R to UTF-8 will cause sorti= ng >> regression. Russian UTF-8 collation should be able to sort all major >> Russian charsets mentioned, i.e. we need combined table. >> 3) "charmap map.ISO8859-1" declaration is missing (needed mainly for >> using pure ASCII chars mnemonic names). >> >> Even in case above mentioned errors will be removed and the code will = be >> committed afterwards, we should understand that this way (implementing= >> multibyte collation via single byte one) even while being possible is = a >> big hack and slowing sorting down up to 10 times. >> >> Proper "Unicode collation algorithm" is already implemented by ICU and= >> other projects. See >> http://unicode.org/reports/tr10/ >> It will be better if someone adopt it instead of hacks. >> >=20 >=20 > If you have a different patch, I'd appreciate seeing it. =20 I don't have a different patch. In case you have enough time to fix above mentioned obstacles, I can review yours (or somebody else's) one. "No code" situation doesn't mean wrong code can be committed. Do it properly even when it is a hack. --=20 http://ache.vniz.net/ --cpMjnvqgx8hIIMiisNcgSOWqhf4qoBnWx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlM/eiMACgkQVg5YK5ZEdN1tvwCcDf+on6g+N/KZ2c3qD7zxNCmN YKsAoKt2mzGExaqJxIpkfHhVpzHv1VMp =1bq4 -----END PGP SIGNATURE----- --cpMjnvqgx8hIIMiisNcgSOWqhf4qoBnWx--