Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 31 Aug 2011 06:48:00 +0000 (UTC)
From:      "Andrey V. Elsukov" <ae@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org
Subject:   svn commit: r225283 - stable/7/sys/ufs/ufs
Message-ID:  <201108310648.p7V6m0MN087003@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ae
Date: Wed Aug 31 06:48:00 2011
New Revision: 225283
URL: http://svn.freebsd.org/changeset/base/225283

Log:
  MFC r225104:
    Fix lock leak.
  
    Reported by:	Alex Lyashkov

Modified:
  stable/7/sys/ufs/ufs/ufs_extattr.c
Directory Properties:
  stable/7/sys/   (props changed)
  stable/7/sys/cddl/contrib/opensolaris/   (props changed)
  stable/7/sys/contrib/dev/acpica/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)

Modified: stable/7/sys/ufs/ufs/ufs_extattr.c
==============================================================================
--- stable/7/sys/ufs/ufs/ufs_extattr.c	Wed Aug 31 06:47:39 2011	(r225282)
+++ stable/7/sys/ufs/ufs/ufs_extattr.c	Wed Aug 31 06:48:00 2011	(r225283)
@@ -1032,14 +1032,14 @@ vop_setextattr {
 	struct ufsmount *ump = VFSTOUFS(mp); 
 	int error;
 
-	ufs_extattr_uepm_lock(ump, ap->a_td);
-
 	/*
 	 * XXX: No longer a supported way to delete extended attributes.
 	 */
 	if (ap->a_uio == NULL)
 		return (EINVAL);
 
+	ufs_extattr_uepm_lock(ump, ap->a_td);
+
 	error = ufs_extattr_set(ap->a_vp, ap->a_attrnamespace, ap->a_name,
 	    ap->a_uio, ap->a_cred, ap->a_td);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201108310648.p7V6m0MN087003>