Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Jan 2003 13:18:02 +0300 (MSK)
From:      Maxim Konovalov <maxim@macomnet.ru>
To:        Wiktor Niesiobedzki <w@evip.pl>
Cc:        current@FreeBSD.ORG
Subject:   Re: IPFW2 skipto + logging
Message-ID:  <20030114131710.W67685@news1.macomnet.ru>
In-Reply-To: <20030113162056.GB6882@mail.evip.pl>
References:  <20021110173443.A5529@mail.evip.pl> <20030112165156.G22175@news1.macomnet.ru> <20030113162056.GB6882@mail.evip.pl>

next in thread | previous in thread | raw e-mail | index | archive | help
On 17:20+0100, Jan 13, 2003, Wiktor Niesiobedzki wrote:

> On Sun, Jan 12, 2003 at 04:52:53PM +0300, Maxim Konovalov wrote:
> >
> > Hello,
> >
> > Please try a next patch:
> >
> It seems, that now logging with skipto is working correctly (I get expected
> results), but funny thing, when there is no log rule, the skipto command won't
> work.

Yes, my bad. Corrected patch:

Index: sys/netinet/ip_fw2.c
===================================================================
RCS file: /home/ncvs/src/sys/netinet/ip_fw2.c,v
retrieving revision 1.22
diff -u -r1.22 ip_fw2.c
--- sys/netinet/ip_fw2.c	27 Dec 2002 17:43:25 -0000	1.22
+++ sys/netinet/ip_fw2.c	14 Jan 2003 10:16:30 -0000
@@ -1180,6 +1180,8 @@

 	/* look for action, in case it is a skipto */
 	cmd = ACTION_PTR(me);
+	if (cmd->opcode == O_LOG)
+		cmd += F_LEN(cmd);
 	if ( cmd->opcode == O_SKIPTO )
 		for (rule = me->next; rule ; rule = rule->next)
 			if (rule->rulenum >= cmd->arg1)

%%%

-- 
Maxim Konovalov, MAcomnet, Internet Dept., system engineer
phone: +7 (095) 796-9079, mailto:maxim@macomnet.ru


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030114131710.W67685>