From owner-freebsd-arch Sun Jun 3 20: 0:50 2001 Delivered-To: freebsd-arch@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 7C3E437B405 for ; Sun, 3 Jun 2001 20:00:47 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id NAA27924; Mon, 4 Jun 2001 13:00:40 +1000 Date: Mon, 4 Jun 2001 12:59:02 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Mike Barcroft Cc: freebsd-arch@freebsd.org, Mike Heffner Subject: Re: Removing __P() (was Re: whois(1) patch) In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 3 Jun 2001, Mike Barcroft wrote: > On 6/2/01 9:23 AM, Bruce Evans at bde@zeta.org.au wrote: > > > On Fri, 1 Jun 2001, Mike Barcroft wrote: > > > >> Does anyone have any objections to removing __P() and converting prototypes > >> to ANSI C, as part of binary cleaning up/auditing? > > > > Yes. It subtracts value and gives more changes to audit. > > Sorry, I didn't state that question very clearly. I want to silence > warnings with WARNS=2 enabled by converting some variables to const char *. > Since I'm converting variables to ANSI C types, it makes no sense to care > along the __P() support shims because it won't compile on K&R anyway. Am I > correct in my assertion? Not completely. "const" can usually be defined away by compiling with -Dconst=. has some support for sort of the reverse of this -- it defines away "const" and some other keywords by default if the compiler is "gcc -traditional", but compiling with -DNO_ANSI_KEYWORDS prevents this. Very old programs may have variables named "const" and defining away "const" would just break them, but defining away "const" usually works for K&R programs. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message