From owner-freebsd-bugs@FreeBSD.ORG Thu Dec 18 06:30:22 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0ACC916A4CE for ; Thu, 18 Dec 2003 06:30:22 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 791D443D4C for ; Thu, 18 Dec 2003 06:30:16 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) hBIEUGFR028787 for ; Thu, 18 Dec 2003 06:30:16 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id hBIEUGtN028786; Thu, 18 Dec 2003 06:30:16 -0800 (PST) (envelope-from gnats) Resent-Date: Thu, 18 Dec 2003 06:30:16 -0800 (PST) Resent-Message-Id: <200312181430.hBIEUGtN028786@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Valentin Nechayev Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2438B16A4CE for ; Thu, 18 Dec 2003 06:29:33 -0800 (PST) Received: from grizzly.carrier.kiev.ua (grizzly.carrier.kiev.ua [193.193.193.138]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4813E43D4C for ; Thu, 18 Dec 2003 06:29:31 -0800 (PST) (envelope-from netch@grizzly.carrier.kiev.ua) Received: from grizzly.carrier.kiev.ua (localhost [127.0.0.1]) hBIETSdB096208; Thu, 18 Dec 2003 16:29:28 +0200 (EET) (envelope-from netch@grizzly.carrier.kiev.ua) Received: (from root@localhost) by grizzly.carrier.kiev.ua (8.12.10/8.12.10/Submit) id hBIESgfk096193; Thu, 18 Dec 2003 16:28:42 +0200 (EET) (envelope-from netch) Message-Id: <200312181428.hBIESgfk096193@grizzly.carrier.kiev.ua> Date: Thu, 18 Dec 2003 16:28:42 +0200 (EET) From: Valentin Nechayev To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/60367: Erroneous "(core dumped)" in process death message X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Valentin Nechayev List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2003 14:30:22 -0000 >Number: 60367 >Category: kern >Synopsis: Erroneous "(core dumped)" in process death message >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Dec 18 06:30:15 PST 2003 >Closed-Date: >Last-Modified: >Originator: Valentin Nechayev >Release: FreeBSD 5.2-RC-20031208 i386 >Organization: private >Environment: FreeBSD 5.2-RC FreeBSD 4.8-RELEASE >Description: On mortal signal, sigexit() in sys/kern/kern_sig.c calls coredump() for some signals (with SA_CORE flag in property table) and marks exit status with WCOREFLAG if it returned 0. coredump() in the same source file returns 0 on successful core write, and errno codes in most cases, but not when core dump is prohibited by resource limit (p->p_rlimit[RLIMIT_CORE].rlim_cur), instead returning 0. I think it is simply typo. As result, kernel says "process exited on signal N (core dumped)" when no core was even supposed to be dumped. >How-To-Repeat: ulimit -Sc 0 (in sh/bash) and run something which deads on SIGSEGV. >Fix: For 5.2: --- kern_sig.c.0 Mon Nov 3 14:09:06 2003 +++ kern_sig.c Thu Dec 18 16:20:00 2003 @@ -2546,7 +2546,7 @@ limit = p->p_rlimit[RLIMIT_CORE].rlim_cur; if (limit == 0) { PROC_UNLOCK(p); - return 0; + return (ENOSPC); } PROC_UNLOCK(p); For 4.8, the same patch is to be apply in some different context (without PROC_UNLOCK). I selected ENOSPC, but really error code doesn't matter while it is !=0. >Release-Note: >Audit-Trail: >Unformatted: