From owner-cvs-src@FreeBSD.ORG Sun May 25 22:11:14 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2EF13106566C; Sun, 25 May 2008 22:11:14 +0000 (UTC) (envelope-from jb@what-creek.com) Received: from what-creek.com (what-creek.com [66.111.37.70]) by mx1.freebsd.org (Postfix) with ESMTP id EDACB8FC1C; Sun, 25 May 2008 22:11:13 +0000 (UTC) (envelope-from jb@what-creek.com) Received: by what-creek.com (Postfix, from userid 102) id 290F173316; Sun, 25 May 2008 22:11:13 +0000 (GMT) Date: Sun, 25 May 2008 22:11:12 +0000 From: John Birrell To: Robert Watson Message-ID: <20080525221112.GH5179@what-creek.com> References: <200805250248.m4P2mv8U026913@repoman.freebsd.org> <20080525180014.S63463@fledge.watson.org> <20080525195955.GB5179@what-creek.com> <20080525225523.F36357@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080525225523.F36357@fledge.watson.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@FreeBSD.org, John Birrell , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 May 2008 22:11:14 -0000 On Sun, May 25, 2008 at 11:00:40PM +0100, Robert Watson wrote: > I think you should consider backing out the change -- the point of "make > universe" is to build as much as we possibly can of the tree, including all > variations on architectures, as many obscure kernel configurations as we > can find, etc. People run make universe to confirm that their changes > haven't broken the build for as many cases as possible, and sun4v remains a > valid case to detect. > I will back out the change, but I think you are making the 'universe' target out to be more than was intended. We used to talk about tiers. We seem to have lost sight of that. > If you think we should write off sun4v at this point, which may well be a > valid proposal, we should have the larger discussion about that before we > remove it from make universe unless we have a pretty practical reason > otherwise (i.e., dtrace and sun4v are fundamentally incompatible). This isn't related to DTrace. It's more about what builds developers are expected to do before committing stuff. Much of the buildworld breakage over the last month would have been detected if a universe build had been done. Even the current breakage. -- John Birrell