From owner-svn-src-all@freebsd.org Mon Dec 12 15:17:58 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 282C4C73DA0; Mon, 12 Dec 2016 15:17:58 +0000 (UTC) (envelope-from jchandra@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EBD55D6A; Mon, 12 Dec 2016 15:17:57 +0000 (UTC) (envelope-from jchandra@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id uBCFHvUQ084813; Mon, 12 Dec 2016 15:17:57 GMT (envelope-from jchandra@FreeBSD.org) Received: (from jchandra@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id uBCFHvP5084812; Mon, 12 Dec 2016 15:17:57 GMT (envelope-from jchandra@FreeBSD.org) Message-Id: <201612121517.uBCFHvP5084812@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jchandra set sender to jchandra@FreeBSD.org using -f From: "Jayachandran C." Date: Mon, 12 Dec 2016 15:17:57 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r309890 - head/sys/dev/pci X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Dec 2016 15:17:58 -0000 Author: jchandra Date: Mon Dec 12 15:17:56 2016 New Revision: 309890 URL: https://svnweb.freebsd.org/changeset/base/309890 Log: Increase interrupt cells in generic_pcie_fdt_route_interrupt ARM GIC specification in device trees use 3 cells, so the current limit of 2 causes the last cell to be dropped. This in turn can cause the interrupt polarity and trigger settings to be incorrect. Increase the limit to 4 which should handle all reasonable cases. This fixes issues seen in QEMU when registering PCI interrupts. Modified: head/sys/dev/pci/pci_host_generic_fdt.c Modified: head/sys/dev/pci/pci_host_generic_fdt.c ============================================================================== --- head/sys/dev/pci/pci_host_generic_fdt.c Mon Dec 12 13:13:48 2016 (r309889) +++ head/sys/dev/pci/pci_host_generic_fdt.c Mon Dec 12 15:17:56 2016 (r309890) @@ -269,7 +269,7 @@ generic_pcie_fdt_route_interrupt(device_ { struct generic_pcie_fdt_softc *sc; struct ofw_pci_register reg; - uint32_t pintr, mintr[2]; + uint32_t pintr, mintr[4]; phandle_t iparent; int intrcells;