From owner-cvs-all Wed May 5 9:14:34 1999 Delivered-To: cvs-all@freebsd.org Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141]) by hub.freebsd.org (Postfix) with ESMTP id 736E114ECA; Wed, 5 May 1999 09:14:26 -0700 (PDT) (envelope-from nate@mt.sri.com) Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id KAA10259; Wed, 5 May 1999 10:14:19 -0600 (MDT) (envelope-from nate@rocky.mt.sri.com) Received: by mt.sri.com (SMI-8.6/SMI-SVR4) id KAA16880; Wed, 5 May 1999 10:14:18 -0600 Date: Wed, 5 May 1999 10:14:18 -0600 Message-Id: <199905051614.KAA16880@mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: obrien@FreeBSD.ORG Cc: Dima Ruban , Bill Paul , Nate Williams , committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pccard pccard.c In-Reply-To: <19990505091025.A31000@dragon.nuxi.com> References: <19990505053731.C46F215822@hub.freebsd.org> <199905050652.XAA40357@burka.rdy.com> <19990505091025.A31000@dragon.nuxi.com> X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > Actually the logic in /etc/rc.pccard is way very fragile. It runs > > builtin=`kldstat -v -i 1 | grep pcic | awk '{print $2}'` > > which on my Vaio 505tx gives: > > pcic_pci pcic > > And the result if the `kldstat' is tested as: > > if [ "$builtin" = "pcic" ]; then > echo "PCIC module compiled in" > else > kldload .... > > which of course bombs for me. Diking /kld/pcic.ko does the job of > course. Feel free to make it more robust. Unfortunately, I have no way of testing it, but I committed the code simply because it had to have been better than what was there before. :( Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message