From owner-cvs-all Tue Mar 27 15:49:38 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (awfulhak.demon.co.uk [194.222.196.252]) by hub.freebsd.org (Postfix) with ESMTP id 304A237B718; Tue, 27 Mar 2001 15:49:14 -0800 (PST) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.3/8.11.3) with ESMTP id f2RNnaT64830; Wed, 28 Mar 2001 00:49:36 +0100 (BST) (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.3/8.11.3) with ESMTP id f2RGN2L00795; Tue, 27 Mar 2001 17:23:02 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200103271623.f2RGN2L00795@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Brian Somers , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kmod.mk In-Reply-To: Message from Ruslan Ermilov of "Tue, 27 Mar 2001 16:14:04 +0300." <20010327161404.D56258@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 27 Mar 2001 17:23:02 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > On Tue, Mar 27, 2001 at 01:18:02PM +0100, Brian Somers wrote: > > > * Ruslan Ermilov [010327 03:55] wrote: > > > > On Tue, Mar 27, 2001 at 03:50:45AM -0800, Ruslan Ermilov wrote: > > > > > ru 2001/03/27 03:50:45 PST > > > > > > > > > > Modified files: > > > > > sys/conf kmod.mk > > > > > Log: > > > > > Reflect recent bsd.man.mk changes here, but do not assign the > > > > > default MAN=${KMOD}.4 value for now. This feature was broken > > > > > before, and enabling it now would cause 92 Makefiles to fail. > > > > > > > > > > Revision Changes Path > > > > > 1.100 +9 -6 src/sys/conf/kmod.mk > > > > > > > > > Should I fix all these 92 Makefiles (they do not have NOMAN=) and > > > > enable this feature, or should I drop the bsd.man.mk support from > > > > kmod.mk completely? No module installs manpages for now. > > > > > > How about inverting the logic? meaning they must have a MAN= if > > > they want pages installed? > > > > I believe both NetBSD & OpenBSD have it the NOMAN way. It'd be nice > > to be consistent (unless anyone has a particularly good reason for us > > not to be). > > > You are probably mistaken. > > OpenBSD has it this way in their bsd.lkm.mk: > > .if !defined(MAN) > MAN= ${LKM}.1 > .endif # !defined(MAN) > > > NetBSD has it this way in their bsd.kmod.mk: > > .if !defined(MAN) > MAN= ${KMOD}.4 > .endif Yes, you're right. I did a couple of tests in src/bin/date/ on each machine. Date isn't a module :-/ My apologies ! > Cheers, > -- > Ruslan Ermilov Oracle Developer/DBA, > ru@sunbay.com Sunbay Software AG, > ru@FreeBSD.org FreeBSD committer, > +380.652.512.251 Simferopol, Ukraine > > http://www.FreeBSD.org The Power To Serve > http://www.oracle.com Enabling The Information Age -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message