From nobody Mon Jan 12 17:33:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dqfbp2BRpz6Ns67 for ; Mon, 12 Jan 2026 17:33:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dqfbn47xFz472R for ; Mon, 12 Jan 2026 17:33:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768239189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6fLtggXAKLhBG8yNbnuoGm4lqsIgSZVnxibn8bLtfsI=; b=ldeFEFihXhPKbZEolMzGoqZ4Qi8OUbCe9FHSA23OJXDJD6nbb1OSW72L70JfVxIAWhDK53 OJX1oX1YfOFbTYnsHNwwGuEwghPUdoUT5LJhmJPqGUMIhsE08b7UKlXdzxcMHjlRj42xK+ tTooqtANowlws9QOOugl67z54Beo5Dn3YM27RSH7GGu5bu1vAir2Cj0sVuJ1HuyKPP8L0S kaDfNXaK431rOsYxfaZq0mnWEexw22m9dVhwIK/smLDjxIhiXTYChHZg711mQDKZRjKegZ hKz2+7Gp58fuSzuzkAmttpOYMPa9cMueGzxAEDVEgFiLk4uCK6AxwMwRQawf4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768239189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6fLtggXAKLhBG8yNbnuoGm4lqsIgSZVnxibn8bLtfsI=; b=mWzg7QObk91YLBOJgYPB7nOYtyZjUbzqreGZC2yOHCU65m7TWYQyDSKObE6VAwNAm6+jOK D4Lh2PwQAwodgaz8jbtXhOlvJBTH1SpQwhhfyYK6Yy8tRV+hvlgjCtM/bHaiklfcm4s5nw VO5nvY5ubTZ7aPBgCeNxa8Lyu9TM8ZfD0NFbtXYWMYkIYLAhTM5pU+P0H5P7b3eiZgwqsi ROhZjj/p2rkyGOCCko3hWozErGeDRjH1NrZ3ow97zzcVZxIYpwTGyTjJDdYKDHIJuEyUyo vkuNiQxhPSS8ZlNgVObn3fq8db5YDRq/ucCbwMBd0mnZgaAkWyAi1npzR/kTQg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768239189; a=rsa-sha256; cv=none; b=KF6CzFdNHTyOquqtjR4MAjuRtF3xKvU3J++C5vMpg3v8AnfuIJ3i0cZA69DiIu/V8c3Bzu dLbp3TKtJdAIc6RHGlr2B0sBIUvgE6OXrt9X1ooaaWY9NbfVJ5UDToey1e7g/qWruQI+4U uMPSpS1oJsqNJbu+kmHtGCwyvravwaG5vVdbU9OxSnUPvT2V1SIFxkwGK1QO71+Q/oOXNX XIMZGid5gCcy/Q4GaT6SjrLa0lw46bZuABf+dE36KFk2v545efpc9wkMAT/7SsCs3Nm6Dm +zH79M2KjvLeRUe0hwUwoBtksclVaacICU+rDpah8yFNGF5MmOh1KHUmpsdhCw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dqfbn3fCnzc1V for ; Mon, 12 Jan 2026 17:33:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39715 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 12 Jan 2026 17:33:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: 00d2b1b0c4d4 - stable/14 - ng_tty: avoid the sign extention of char List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 00d2b1b0c4d48bd8daf0b01851e694a7dff12fe1 Auto-Submitted: auto-generated Date: Mon, 12 Jan 2026 17:33:09 +0000 Message-Id: <69653055.39715.20f67c5a@gitrepo.freebsd.org> The branch stable/14 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=00d2b1b0c4d48bd8daf0b01851e694a7dff12fe1 commit 00d2b1b0c4d48bd8daf0b01851e694a7dff12fe1 Author: Ahmad Khalifa AuthorDate: 2026-01-06 02:07:29 +0000 Commit: Ahmad Khalifa CommitDate: 2026-01-12 17:26:33 +0000 ng_tty: avoid the sign extention of char When c is compared to sc->hotchar, both undergo integer promotion, which can lead to c being sign extended. Fix this by casting c to an unsigned char. Reviewed by: kevans MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54544 (cherry picked from commit 9b2478f60bfda663c84b48e272a2293159e1b0a0) --- sys/netgraph/ng_tty.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c index 0e3230a66f66..200a72336110 100644 --- a/sys/netgraph/ng_tty.c +++ b/sys/netgraph/ng_tty.c @@ -489,7 +489,8 @@ ngt_rint(struct tty *tp, char c, int flags) m->m_pkthdr.len++; /* Ship off mbuf if it's time */ - if (sc->hotchar == -1 || c == sc->hotchar || m->m_len >= MHLEN) { + if (sc->hotchar == -1 || (u_char)c == sc->hotchar || + m->m_len >= MHLEN) { sc->m = NULL; NG_SEND_DATA_ONLY(error, sc->hook, m); /* Will queue */ }