From owner-cvs-all@FreeBSD.ORG  Tue Dec  4 20:44:03 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2B92616A41A;
	Tue,  4 Dec 2007 20:44:03 +0000 (UTC)
	(envelope-from fjoe@samodelkin.net)
Received: from neo.samodelkin.net (samodelkin.net [195.62.0.66])
	by mx1.freebsd.org (Postfix) with ESMTP id A5A1013C4CE;
	Tue,  4 Dec 2007 20:44:02 +0000 (UTC)
	(envelope-from fjoe@samodelkin.net)
Received: by neo.samodelkin.net (Postfix, from userid 10117)
	id 949E417087; Wed,  5 Dec 2007 02:43:59 +0600 (NOVT)
Received: from husky.fjoe.local (gw.nsib.ru [217.117.80.2])
	by neo.samodelkin.net (Postfix) with ESMTP id 144EF17082;
	Wed,  5 Dec 2007 02:43:59 +0600 (NOVT)
Message-ID: <4755BC3B.9040809@samodelkin.net>
Date: Wed, 05 Dec 2007 02:44:43 +0600
From: Max Khon <fjoe@samodelkin.net>
User-Agent: Thunderbird 2.0.0.6 (X11/20071028)
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>
References: <200711232356.lANNu3mp040885@repoman.freebsd.org>
	<864pezer7f.fsf@ds4.des.no> <200712031657.34074.jhb@freebsd.org>
	<20071204172535.GB82261@FreeBSD.org>
In-Reply-To: <20071204172535.GB82261@FreeBSD.org>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
X-Bogosity: No, tests=bogofilter, spamicity=0.000000, version=0.16.4
X-Mailman-Approved-At: Tue, 04 Dec 2007 21:59:32 +0000
Cc: src-committers@freebsd.org, John Baldwin <jhb@freebsd.org>,
	cvs-src@freebsd.org, cvs-all@freebsd.org,
	John Birrell <jb@freebsd.org>, Dag-Erling Sm??rgrav <des@des.no>
Subject: Re: cvs commit: src/sys/netinet/libalias alias_util.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Dec 2007 20:44:03 -0000

Ho!

Alexey Dokuchaev wrote:

>>> John Birrell <jb@FreeBSD.org> writes:
>>>>   Log:
>>>>   Fix strict alias warnings.
>>> A much simpler solution (relative to the previous revision):
>>>
>>> @@ -131,10 +131,10 @@
>>>                 sum += oddbyte;
>>>         }
>>>  /* "Pseudo-header" data */
>>> -       ptr = (u_short *) & (pip->ip_dst);
>>> +       ptr = (void *)&pip->ip_dst;
>>>         sum += *ptr++;
>>>         sum += *ptr;
>>> -       ptr = (u_short *) & (pip->ip_src);
>>> +       ptr = (void *)&pip->ip_src;
>>>         sum += *ptr++;
>>>         sum += *ptr;
>>>         sum += htons((u_short) ntcp);
>> *ptr++ would choke since pointer arith on (void *) is undefined AFAIK.
> 
> I've been under impression that ++ on void * whould simply increase it
> by one.

Nope. Read man 1 gcc about -Wpointer-arith

/fjoe