From owner-freebsd-bugs@FreeBSD.ORG  Wed Aug 18 08:30:39 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 718CB16A4D7
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 18 Aug 2004 08:30:39 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6683F43D2D
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 18 Aug 2004 08:30:39 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i7I8Udg2075896
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 18 Aug 2004 08:30:39 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i7I8UdnH075892;
	Wed, 18 Aug 2004 08:30:39 GMT
	(envelope-from gnats)
Date: Wed, 18 Aug 2004 08:30:39 GMT
Message-Id: <200408180830.i7I8UdnH075892@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
Subject: Re: kern/70611: MBR type no longer visible in GEOM dumps 
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Poul-Henning Kamp <phk@phk.freebsd.dk>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Aug 2004 08:30:39 -0000

The following reply was made to PR kern/70611; it has been noted by GNATS.

From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
To: Michiel Boland <Michiel.Boland@internl.net>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: kern/70611: MBR type no longer visible in GEOM dumps 
Date: Wed, 18 Aug 2004 10:25:23 +0200

 In message <200408180819.i7I8J6CP002734@brakkenstein.nijmegen.internl.net>, Mic
 hiel Boland writes:
 
 >>Number:         70611
 >>Category:       kern
 >>Synopsis:       MBR type no longer visible in GEOM dumps
 
 >>How-To-Repeat:
 >Type sysctl -b kern.geom.dumptxt
 >The ouput contains lines like the following:
 >
 >1 MBR ad0s1 39999504384 512 i 0 o 32256
 >
 >The line above should have a ' ty ' entry appended.
 
 Can you try this patch:
 
 Index: geom_slice.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/geom/geom_slice.c,v
 retrieving revision 1.55
 diff -u -r1.55 geom_slice.c
 --- geom_slice.c	25 Jul 2004 09:41:31 -0000	1.55
 +++ geom_slice.c	18 Aug 2004 08:24:47 -0000
 @@ -465,7 +465,8 @@
  	gp->softc = gsp;
  	gp->start = g_slice_start;
  	gp->spoiled = g_slice_spoiled;
 -	gp->dumpconf = g_slice_dumpconf;
 +	if (gp->dumpconf == NULL)
 +		gp->dumpconf = g_slice_dumpconf;
  	if (gp->class->destroy_geom == NULL)
  		gp->class->destroy_geom = g_slice_destroy_geom;
  	cp = g_new_consumer(gp);
 
 -- 
 Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
 phk@FreeBSD.ORG         | TCP/IP since RFC 956
 FreeBSD committer       | BSD since 4.3-tahoe    
 Never attribute to malice what can adequately be explained by incompetence.