From owner-freebsd-bugs@freebsd.org Thu Jan 7 09:25:28 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4642B4C9D0C for ; Thu, 7 Jan 2021 09:25:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DBLS81KHQz4mHH for ; Thu, 7 Jan 2021 09:25:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 2D4414C9A6D; Thu, 7 Jan 2021 09:25:28 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2D0684C9AA7 for ; Thu, 7 Jan 2021 09:25:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DBLS80jPfz4mKw for ; Thu, 7 Jan 2021 09:25:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0BE2A65FF for ; Thu, 7 Jan 2021 09:25:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1079PRlE074471 for ; Thu, 7 Jan 2021 09:25:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1079PRem074470 for bugs@FreeBSD.org; Thu, 7 Jan 2021 09:25:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 252488] bsdtar fails to work with 128k blocksize Date: Thu, 07 Jan 2021 09:25:28 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.4-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mail@fbsd2.e4m.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2021 09:25:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252488 Bug ID: 252488 Summary: bsdtar fails to work with 128k blocksize Product: Base System Version: 11.4-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: mail@fbsd2.e4m.org Prerequisites: tape written with 128k block size, mt blocksize 131072 bsdtar -tf /dev/sa0 -b 256 gives sa0: request ptr 0x2888ed80 is not on a page boundary; cannot split request bsdtar: Error opening archive: Error reading '/dev/sa0' This seems to be an alignment problem. The problem goes away after aligning the buffer in archive_read_open_filename.c: --- archive_read_open_filename.c.ORI 2020-03-13 08:22:53.000000000 +0100 +++ archive_read_open_filename.c 2021-01-06 10:37:34.176333000 +0100 @@ -359,12 +359,17 @@ new_block_size *=3D 2; mine->block_size =3D new_block_size; } +#if 0 buffer =3D malloc(mine->block_size); +#else + buffer =3D malloc(mine->block_size + 4096); +#endif if (buffer =3D=3D NULL) { archive_set_error(a, ENOMEM, "No memory"); goto fail; } mine->buffer =3D buffer; + mine->buffer =3D (void*)(((u_int32_t)buffer + 4096) & ~4095); mine->fd =3D fd; /* Remember mode so close can decide whether to flush. */ mine->st_mode =3D st.st_mode; This is NO patch to fix the issue -- it's just to show the origin of the problem . A proper patch will probably use PAGESIZE and distinguish between malloc start and aligned buffer (so it can bee free()ed). --=20 You are receiving this mail because: You are the assignee for the bug.=