From owner-freebsd-stable Sun Oct 13 8:22:22 2002 Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 339FB37B401; Sun, 13 Oct 2002 08:22:21 -0700 (PDT) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 95E0343E7B; Sun, 13 Oct 2002 08:22:19 -0700 (PDT) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.12.5/8.12.5) with ESMTP id g9DFMHTJ060383; Sun, 13 Oct 2002 19:22:17 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Sun, 13 Oct 2002 19:22:17 +0400 (MSD) From: Dmitry Morozovsky To: Kelly Yancey Cc: stable@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_subr.c In-Reply-To: <20021013191641.R1640-100000@woozle.rinet.ru> Message-ID: <20021013192019.Y1640-100000@woozle.rinet.ru> X-NCC-RegID: ru.rinet MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 13 Oct 2002, Dmitry Morozovsky wrote: DM> On Sun, 13 Oct 2002, Kelly Yancey wrote: DM> DM> KY> kbyanc 2002/10/13 00:38:41 PDT DM> KY> DM> KY> Modified files: (Branch: RELENG_4) DM> KY> sys/kern vfs_subr.c DM> KY> Log: DM> KY> Use macros rather than fondling implementation details. DM> DM> Kelly, it seems this commit broke -stable (see PR/44007) ... and I can confirm that backing out this change revert -stable to working (patch for band-aiding follows) Sincerely, D.Marck [DM5020, DM268-RIPE, DM3-RIPN] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------ Index: sys/kern/vfs_subr.c =================================================================== RCS file: /home/ncvs/src/sys/kern/vfs_subr.c,v retrieving revision 1.249.2.28 diff -u -r1.249.2.28 vfs_subr.c --- sys/kern/vfs_subr.c 13 Oct 2002 07:38:41 -0000 1.249.2.28 +++ sys/kern/vfs_subr.c 13 Oct 2002 15:17:55 -0000 @@ -1256,7 +1256,7 @@ KASSERT(bp->b_vp != NULL, ("pbrelvp: NULL")); /* XXX REMOVE ME */ - if (!TAILQ_NEXT(bp, b_vnbufs)) { + if (bp->b_vnbufs.tqe_next != NULL) { panic( "relpbuf(): b_vp was probably reassignbuf()d %p %x", bp, To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message