From nobody Thu Jan 26 18:35:28 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P2qC43kbLz3bLgq; Thu, 26 Jan 2023 18:35:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P2qC435szz43Lj; Thu, 26 Jan 2023 18:35:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674758128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dLeFiWhVqQuDi8q4kJ1Am2EZc5mS+wE+/wBWy6tyO9s=; b=GnwlgrHLmvq30ihfZBZ4/W7TWEQ59RvFfWjsQzfWckHTDHdvvwC0vdXDmIt9LRxBs5a+fA +GrgKAiVfCqizB2zzRUOr23nUdkQ0lEtQZWxkUrD1zMFvFEGay+VpRuVz5k9AyD4jSdwL6 ++nQb7lOFf3Jmi47Uj5Qrd+0DuGIiQYF7R399YUP+WiVoqQe6XJs1mi1C2AHHyJRo0QFJu GzNikJXId+gJU4BaJ9x7zRjsEzRSdMxMQfjJUiAFuN5Xlj+7gmniuzdvYO/vIeaz3ogfRJ FE36jdHSn5SGhSyWggF+oz77qI4Yvdv9lTN8DyQtDMM9EsDV8DHOlRTDPlFhLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674758128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dLeFiWhVqQuDi8q4kJ1Am2EZc5mS+wE+/wBWy6tyO9s=; b=q0j6KpHbFWsdgQpV/8Xle5crV1opCUuHGnuei44QPcBfZG+qvQLe33aZrdjucjYFHfBOL6 EgaytUsyiDm23cIGSbHS4kA/bQzuqDO6PvhVApi5E/ZWgEj2B9MBP1xx7uLbtpv0FajrWO ltFqioQaOiPyiiV6lklHvlZzKBEJXFbbGTYFSOPAbaZx/MLhXQ81XtK6q3CAYKYakyoIuv mLJoewQQkJVmrdMCgzuEZztDURABvIe8zeKwBk38YM6sb4IWrLGh+hHAgyPp9SYRmUo8DR iEaRgVtyAXDKMegj/nY6zVbGvzwPJC937LG9Tn3IVd+CGhJl3aXA211EJErV1Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674758128; a=rsa-sha256; cv=none; b=LWX2VRWagBFLXGPp08fRpS8WKdCzRN7E/P4esMdp8NAU9LjSSWBVrbAYrOHvrsj9ceN9tV T5Nc1A9KUpuLX6PBNj0T777xvY4qP64Pd9NPNM30yqfTft4L6fGnyEQiQtS/F40ESvkRbx W7MmLAjqUNRO+gcePIbIrjZ7PkMUEzTcwV4WZ4zcwHXvxA20JcNzNxtY0d2gZmtPY32D+F TN+ipLaS8cBxQ+Etxc0zE+QrM1PjY6vNvNu7/CCYB3KzMTL1HM+p1AQX8YoX+x23gf1RBz 5Jt5LY2J6SYoET83QLA1xFqyQtk8NokyiFomBriSB6R+jjN27/AaKGE+UBBGxg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P2qC424Dgzfc9; Thu, 26 Jan 2023 18:35:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30QIZSTs005617; Thu, 26 Jan 2023 18:35:28 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30QIZS4D005616; Thu, 26 Jan 2023 18:35:28 GMT (envelope-from git) Date: Thu, 26 Jan 2023 18:35:28 GMT Message-Id: <202301261835.30QIZS4D005616@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 98796fffb6cd - stable/13 - bhyve/ioapic: only account for asserted line in level mode List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 98796fffb6cd86d604f3f3c13f2a777346a2f0fa Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=98796fffb6cd86d604f3f3c13f2a777346a2f0fa commit 98796fffb6cd86d604f3f3c13f2a777346a2f0fa Author: Roger Pau Monné AuthorDate: 2021-01-19 12:41:03 +0000 Commit: John Baldwin CommitDate: 2023-01-26 18:33:06 +0000 bhyve/ioapic: only account for asserted line in level mode After modifying a redirection entry only try to inject an interrupt if the pin is in level mode, pins in edge mode shouldn't take into account the line assert status as they are triggered by edge changes, not the line status itself. Reviewed by: grehan Differential revision: https://reviews.freebsd.org/D28237 (cherry picked from commit d7d067698a38a3464a58eb34f68f63e529c45136) --- sys/amd64/vmm/io/vioapic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/amd64/vmm/io/vioapic.c b/sys/amd64/vmm/io/vioapic.c index 682e862da63e..941f7c7364bc 100644 --- a/sys/amd64/vmm/io/vioapic.c +++ b/sys/amd64/vmm/io/vioapic.c @@ -364,9 +364,11 @@ vioapic_write(struct vioapic *vioapic, int vcpuid, uint32_t addr, uint32_t data) /* * Generate an interrupt if the following conditions are met: * - previous interrupt has been EOIed + * - pin trigger mode is level * - pin level is asserted */ if ((vioapic->rtbl[pin].reg & IOART_REM_IRR) == 0 && + (vioapic->rtbl[pin].reg & IOART_TRGRMOD) == IOART_TRGRLVL && (vioapic->rtbl[pin].acnt > 0)) { VIOAPIC_CTR2(vioapic, "ioapic pin%d: asserted at rtbl " "write, acnt %d", pin, vioapic->rtbl[pin].acnt);