From owner-freebsd-hackers  Sat Jan 12 16:56:28 2002
Delivered-To: freebsd-hackers@freebsd.org
Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11])
	by hub.freebsd.org (Postfix) with SMTP id 6E27D37B41D
	for <FreeBSD-hackers@FreeBSD.ORG>; Sat, 12 Jan 2002 16:56:25 -0800 (PST)
Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP
          id <aa91209@salmon>; 13 Jan 2002 00:56:24 +0000 (GMT)
To: Matthew Dillon <dillon@apollo.backplane.com>
Cc: Alfred Perlstein <bright@mu.org>, "Alan L. Cox" <alc@imimic.com>,
	FreeBSD-hackers@FreeBSD.ORG
Subject: Re: Need review of NFS patch set for server .. missing/wrong vput() issues 
In-Reply-To: Your message of "Sun, 13 Jan 2002 00:43:40 GMT."
             <200201130043.aa90380@salmon.maths.tcd.ie> 
Date: Sun, 13 Jan 2002 00:56:24 +0000
From: Ian Dowse <iedowse@maths.tcd.ie>
Message-ID:  <200201130056.aa91209@salmon.maths.tcd.ie>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

In message <200201130043.aa90380@salmon.maths.tcd.ie>, Ian Dowse writes:
>I don't think this is necessary, because the cleanup code at the
>end of nfsrv_mknod() catches any cases where nd.ni_vp was not
>released earlier. It would be harmless to add it though.

Oops, I missed a 'return (0);' when reading the code. You're quite
correct here; the first part of the patch looks correct, and could
certainly cause vput's to be forgotten. I'll try to reproduce this
now.

It's just the vp == dvp stuff that is ok as it is.

Ian

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message