From owner-svn-ports-head@FreeBSD.ORG  Mon May 19 09:15:34 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id EE8F8DD0;
 Mon, 19 May 2014 09:15:34 +0000 (UTC)
Received: from fep28.mx.upcmail.net (fep28.mx.upcmail.net [62.179.121.48])
 by mx1.freebsd.org (Postfix) with ESMTP id AF1D42349;
 Mon, 19 May 2014 09:15:33 +0000 (UTC)
Received: from edge04.upcmail.net ([192.168.13.239]) by viefep28-int.chello.at
 (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP
 id <20140519091525.TNAO18392.viefep28-int.chello.at@edge04.upcmail.net>;
 Mon, 19 May 2014 11:15:25 +0200
Received: from crashalot.kantoor.acservices.nl ([213.127.215.2])
 by edge04.upcmail.net with edge
 id 3lFQ1o01W03gjjH03lFQpC; Mon, 19 May 2014 11:15:25 +0200
X-SourceIP: 213.127.215.2
Message-ID: <1400490882.1509.5.camel@crashalot.rainbow-runner.nl>
Subject: Re: svn commit: r354416 - head/devel/goffice
From: Koop Mast <kwm@FreeBSD.org>
To: Tijl Coosemans <tijl@FreeBSD.org>
Date: Mon, 19 May 2014 11:14:42 +0200
In-Reply-To: <20140518181413.5e4f21bc@kalimero.tijl.coosemans.org>
References: <201405181306.s4ID6RCs085888@svn.freebsd.org>
 <20140518181413.5e4f21bc@kalimero.tijl.coosemans.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.2 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 May 2014 09:15:35 -0000

On zo, 2014-05-18 at 18:14 +0200, Tijl Coosemans wrote:
> On Sun, 18 May 2014 13:06:27 +0000 (UTC) Koop Mast wrote:
> > Author: kwm
> > Date: Sun May 18 13:06:27 2014
> > New Revision: 354416
> > URL: http://svnweb.freebsd.org/changeset/ports/354416
> > QAT: https://qat.redports.org/buildarchive/r354416/
> > 
> > Log:
> >   Switch to USES=libtool:keepla instead of plain USES=libtool.
> >   
> >   Fixes:
> >   editors/abiword: libtool: link: cannot find the library
> >   `/usr/local/lib/libgoffice-0.8.la' or unhandled argument
> >   `/usr/local/lib/libgoffice-0.8.la'
> >   
> >   PR:		ports/189909
> >   Submitted by:	"O. Hartmann" <ohartman@zedat.fu-berlin.de>
> 
> The problem is actually in abiword.  It links with the installed libabiword.la
> which may still refer to libgoffice-0.8.la.  The attached patch should fix
> that by replacing "-Lsrc -labiword" with "src/libabiword.la" in configure and
> switching around "PLUGIN_LIBS src/libabiword.la" because PLUGIN_LIBS contains
> -L/usr/local/lib.  So if it's ok with you I'd like to revert this commit.

Ah that makes sense, sneaky. I was more concerned to fix it. The patch
looks fine, but my brain melts with the amount of escaping :)

Go ahead with commiting the patch and reverting the goffice change. But
could you add a comment explaining why the change is needed in abiword? 

> Redports test:
> https://redports.org/buildarchive/20140518153400-35443/
> During build phase "../../src/.libs/libabiword-2.8.so" is used now instead
> of "-labiword-2.8" and during install phase when several modules are
> relinked "-L$STAGEDIR" appears before "-L/usr/local/lib" now.