Date: Mon, 19 May 2014 11:14:42 +0200 From: Koop Mast <kwm@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r354416 - head/devel/goffice Message-ID: <1400490882.1509.5.camel@crashalot.rainbow-runner.nl> In-Reply-To: <20140518181413.5e4f21bc@kalimero.tijl.coosemans.org> References: <201405181306.s4ID6RCs085888@svn.freebsd.org> <20140518181413.5e4f21bc@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On zo, 2014-05-18 at 18:14 +0200, Tijl Coosemans wrote: > On Sun, 18 May 2014 13:06:27 +0000 (UTC) Koop Mast wrote: > > Author: kwm > > Date: Sun May 18 13:06:27 2014 > > New Revision: 354416 > > URL: http://svnweb.freebsd.org/changeset/ports/354416 > > QAT: https://qat.redports.org/buildarchive/r354416/ > > > > Log: > > Switch to USES=libtool:keepla instead of plain USES=libtool. > > > > Fixes: > > editors/abiword: libtool: link: cannot find the library > > `/usr/local/lib/libgoffice-0.8.la' or unhandled argument > > `/usr/local/lib/libgoffice-0.8.la' > > > > PR: ports/189909 > > Submitted by: "O. Hartmann" <ohartman@zedat.fu-berlin.de> > > The problem is actually in abiword. It links with the installed libabiword.la > which may still refer to libgoffice-0.8.la. The attached patch should fix > that by replacing "-Lsrc -labiword" with "src/libabiword.la" in configure and > switching around "PLUGIN_LIBS src/libabiword.la" because PLUGIN_LIBS contains > -L/usr/local/lib. So if it's ok with you I'd like to revert this commit. Ah that makes sense, sneaky. I was more concerned to fix it. The patch looks fine, but my brain melts with the amount of escaping :) Go ahead with commiting the patch and reverting the goffice change. But could you add a comment explaining why the change is needed in abiword? > Redports test: > https://redports.org/buildarchive/20140518153400-35443/ > During build phase "../../src/.libs/libabiword-2.8.so" is used now instead > of "-labiword-2.8" and during install phase when several modules are > relinked "-L$STAGEDIR" appears before "-L/usr/local/lib" now.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1400490882.1509.5.camel>