From owner-freebsd-arm@freebsd.org Mon Jan 13 16:53:38 2020 Return-Path: Delivered-To: freebsd-arm@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F16AD1E2E3B for ; Mon, 13 Jan 2020 16:53:38 +0000 (UTC) (envelope-from freebsd-arm@dino.sk) Received: from mailhost.netlabit.sk (mailhost.netlabit.sk [84.245.65.72]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47xKRP4GF3z3HF9; Mon, 13 Jan 2020 16:53:37 +0000 (UTC) (envelope-from freebsd-arm@dino.sk) Received: from zeta.dino.sk (fw3.dino.sk [84.245.95.254]) (AUTH: LOGIN milan) by mailhost.netlabit.sk with ESMTPA; Mon, 13 Jan 2020 17:53:34 +0100 id 00E5483C.5E1CA08E.0000A0AD Date: Mon, 13 Jan 2020 17:53:34 +0100 From: Milan Obuch To: Ian Lepore Cc: Warner Losh , freebsd-arm@freebsd.org Subject: Re: Zynq qspi driver https://reviews.freebsd.org/D14698 Message-ID: <20200113175334.7b4b5e4a@zeta.dino.sk> In-Reply-To: <9f0d3934c9b715696643f0ea93de8e589355a560.camel@freebsd.org> References: <20190818121741.7bd82a63@zeta.dino.sk> <9f0d3934c9b715696643f0ea93de8e589355a560.camel@freebsd.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i386-portbld-freebsd11.3) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47xKRP4GF3z3HF9 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of freebsd-arm@dino.sk designates 84.245.65.72 as permitted sender) smtp.mailfrom=freebsd-arm@dino.sk X-Spamd-Result: default: False [-4.00 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; URL_IN_SUBJECT(1.00)[reviews.freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[dino.sk]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[72.65.245.84.list.dnswl.org : 127.0.10.0]; IP_SCORE(-2.70)[ip: (-7.98), ipnet: 84.245.64.0/18(-3.99), asn: 16160(-1.61), country: SK(0.09)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:16160, ipnet:84.245.64.0/18, country:SK]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2020 16:53:39 -0000 On Sun, 18 Aug 2019 09:21:31 -0600 Ian Lepore wrote: > On Sun, 2019-08-18 at 08:23 -0600, Warner Losh wrote: > > On Sun, Aug 18, 2019 at 4:18 AM Milan Obuch > > wrote: > > > > > Hi, > > > > > > I was able to use in subject mentioned driver on my Zybo Z7 > > > board. I just downloaded zy7_qspi.c file, put it in > > > sys/arm/xilinx directory and all other necessary patches applied > > > per hand to 12.0-STABLE source tree. > > > > > > I am able to read and write flash attached to qspi on my board. > > > u-boot uses qspi flash for environment storage so some caution > > > should be taken with that. > > > > > > Question: what needs to be done in order to get this driver into > > > official source tree? Is there any show stopper? My experience is > > > - it Just Works (tm). > > > > > > > It looks almost ready to my eye. Not sure what the hold up is. > > > > Warner > > > > I think I'm probably among those who dropped the ball on this. I > vaguely remember that when it was submitted, I thought I was going to > be buying a xilinx development board soon and I'd just test and commit > it after that. But then plans changed at $work and the devel board > thing never happened. > > -- Ian > Hi, is there still something to do? Recently I have access to another Zynq based board, MYD-Y7Z010 from MYIR tech, this driver works here too. Flash used on this board is reported as w25q128, on Zybo Z7 s25fl128. Regards, Milan