From owner-svn-src-head@freebsd.org  Tue Jul 14 11:01:39 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6BBA999CBC9;
 Tue, 14 Jul 2015 11:01:39 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D712F796;
 Tue, 14 Jul 2015 11:01:38 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t6EB1QtP079344
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Tue, 14 Jul 2015 14:01:26 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t6EB1QtP079344
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id t6EB1QWl079343;
 Tue, 14 Jul 2015 14:01:26 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Tue, 14 Jul 2015 14:01:26 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Ed Schouten <ed@nuxi.nl>
Cc: Ed Schouten <ed@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r285404 - head/sys/compat/cloudabi
Message-ID: <20150714110126.GV2404@kib.kiev.ua>
References: <201507111941.t6BJfV1a072539@repo.freebsd.org>
 <20150711194732.GB2404@kib.kiev.ua>
 <CABh_MK=wtpr-zn3N8dV5k7UnVNjv1XZ9ikdmVi8sg-faVr4jQA@mail.gmail.com>
 <20150711205611.GC2404@kib.kiev.ua>
 <CABh_MK=dop1WHCUYz=2rStbVusC9wKONsH+rN-oAaZc8sQ93zA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABh_MK=dop1WHCUYz=2rStbVusC9wKONsH+rN-oAaZc8sQ93zA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jul 2015 11:01:39 -0000

On Tue, Jul 14, 2015 at 12:22:51PM +0200, Ed Schouten wrote:
> Ah, okay. Now I think I understand what you're hinting at. So your
> proposal is to let cloudabi_sys_proc_raise() only call into
> sys_kill(), nothing else. We then reset all signals to their default
> behavior at some point during process startup.
> 
> Let me address this by the time I'm sending out the CloudABI sysentvec
> for review, as that would be the place where I'd need to do that. I'll
> remove the call to kern_sigaction() in the meantime. Does that sound
> all right?

Sounds fine.  But, I do not recomment to use sys_kill(), which is
the FreeBSD syscall implementation.  You should use pksignal(9) or
similar function directly, IMO.  Minor code duplication to create
proper ksiginfo is not critical, while you do not need pfind() or
complications with negative pid values.