From owner-freebsd-stable@FreeBSD.ORG Mon Apr 7 13:33:50 2014 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B3AED970; Mon, 7 Apr 2014 13:33:50 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 38662E87; Mon, 7 Apr 2014 13:33:49 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.8/8.14.8) with ESMTP id s37DXDjk027268 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 7 Apr 2014 17:33:13 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.8/8.14.8/Submit) id s37DXD0r027267; Mon, 7 Apr 2014 17:33:13 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 7 Apr 2014 17:33:13 +0400 From: Gleb Smirnoff To: Oliver Lehmann Subject: Re: r263478 - /stable/10/sys/net/route.h breaks net-snmp Message-ID: <20140407133313.GX44326@FreeBSD.org> References: <20140406101131.Horde.OoOkpfQUTkPO6Q0jKJFQvw7@avocado.salatschuessel.net> <20140407092611.GP44326@glebius.int.ru> <20140407122801.Horde.5xq2r-rKMOXKBCqbSukjFQ5@avocado.salatschuessel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140407122801.Horde.5xq2r-rKMOXKBCqbSukjFQ5@avocado.salatschuessel.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: zi@freebsd.org, ports@freebsd.org, stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Apr 2014 13:33:50 -0000 On Mon, Apr 07, 2014 at 12:28:01PM +0200, Oliver Lehmann wrote: O> > Strange. This is how it builds on my CURRENT: O> > O> > checking for struct rtentry.rt_dst... no O> > checking for struct rtentry.rt_hash... no O> > checking for struct rtentry.rt_next... no O> > checking for struct rtentry.rt_refcnt... no O> > checking for struct rtentry.rt_unit... no O> > checking for struct rtentry.rt_use... no O> > checking type of rtentry structure... unknown O> > checking for struct rtentry... rtentry O> > O> > After that, it compiles fine. O> > O> > In your log it detects 'struct ortentry' and surprisingly prefers it. O> O> Please check 10-STABLE. O> - ortentry is visible O> - rtentry is not visible O> I guess this is the reason why. I didn't checked CURRENT, just grabbed O> up the log via google (I have no CURRENT system atm). My issue is on O> STABLE where you merged this to. I wonder why this API-breakage got O> merged anyway?! The ortentry wasn't part of any API or ABI. It was just defined. I am very surprised that net-snmp picks it and utilizes it during compilation. If it uses the structure anywhere, then it obtains invalid info from it. So that is actually a bug on net-snmp side taking that structure. I guess that in CURRENT, where ortentry is wiped entirely, and net-snmp takes rtentry, we've got the bug accidentially fixed. I'm now running universe build with r263203 merged. If it succeeds, I will merge r263203 removing declaration of ortentry. -- Totus tuus, Glebius.