Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Nov 2012 15:25:00 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r243340 - head/sys/fs/nullfs
Message-ID:  <201211201525.qAKFP0Xq045296@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Tue Nov 20 15:25:00 2012
New Revision: 243340
URL: http://svnweb.freebsd.org/changeset/base/243340

Log:
  Remove the check and panic for an impossible condition. The NULL
  lowervp vnode v_vnlock would cause panic due to NULL pointer
  dereference much earlier.
  
  MFC after:	1 week

Modified:
  head/sys/fs/nullfs/null_subr.c

Modified: head/sys/fs/nullfs/null_subr.c
==============================================================================
--- head/sys/fs/nullfs/null_subr.c	Tue Nov 20 15:23:22 2012	(r243339)
+++ head/sys/fs/nullfs/null_subr.c	Tue Nov 20 15:25:00 2012	(r243340)
@@ -251,8 +251,6 @@ null_nodeget(mp, lowervp, vpp)
 	vp->v_type = lowervp->v_type;
 	vp->v_data = xp;
 	vp->v_vnlock = lowervp->v_vnlock;
-	if (vp->v_vnlock == NULL)
-		panic("null_nodeget: Passed a NULL vnlock.\n");
 	error = insmntque1(vp, mp, null_insmntque_dtr, xp);
 	if (error != 0)
 		return (error);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201211201525.qAKFP0Xq045296>