From nobody Tue Mar 24 10:39:04 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fg63F3NjNz6WV9h for ; Tue, 24 Mar 2026 10:39:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fg63D67Ltz3tg4 for ; Tue, 24 Mar 2026 10:39:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774348744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=066qLbPU9XeZv+axhND/vsSK7C4wvw/4NzYESNzbCFQ=; b=NLW3cDPyLaJgC/mv0w48scVCxfYGiEBkL90lr4YM0Gb4fhMDotoWs3LSIrSbQu2DnteOui jMyHfOXiHCXi4aohbf65LgNbyu8X7q2fXtMXKlw00jZxPxyyMAK/s31vo+YnHRNpTPD2dw QtOhARxJLw/0zNXjpq8H5u37t9VrdOmGKNIDioyoZ16nS4EsZPzlah7iiQFUK9Hve+6AvW iBf/rz+Qlk0imtrPco+bOInQCUidxbDFpFoJkqtf/cwgh4laqG1fKPBoDkvU3FjrC0i4Bf BcKNOJse6IDfXko3UIJPi5ZUnTKz2Be8Y0kF/15yrE4dDZJqPRhagZoy7bjWTg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774348744; a=rsa-sha256; cv=none; b=hnUnGEGX7X+sy2wX+RJCEHFs0RiaFwfCyD2fQsSrJdcYyt0eYeCENmLgdldJYaK/wNme5h 5I3ysZqgezBtPpKGTLLEid3YgDWEeTlD9pOGvDYIRuXanq1DOIoY+BH1HCEDrAUF1LnrRG HhyKsE/DtsId3YqCqBHmmecyvSXy2r0DgsRbsx7EnkMBPzxnnFuZwQa5rVzNKqRnKZR84v oEtzHjOAgsVGIql4470zMvVIHDASvxFBSjGQBqFkYr24PfOMKYFC5l3IoMrfel7JkoYxAk HDm8g8hPFFsie58tbwFWPKCPnmqABO2cSx6puWS9b+1vQMuc1SuWY570w/ltfw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774348744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=066qLbPU9XeZv+axhND/vsSK7C4wvw/4NzYESNzbCFQ=; b=jJPPnjkE23Un0BtJLajztiQnG5m6jimVccO13nCAl4F1WJ1Qm0TDUq9Tz+qbPeicNAin++ jPCCiCukOaqEfoS5SZJv8CEuDyjF4E5Y5iKgm1eC/KaWCCgagN5nHU/iDECOIuKZC+BUDF RtD87x5iVe+B9RzucTZfUHQEHx92h07klWnggCEGp9KIRLhzH9vlDTtgnq+aqEh5PRnxQY XdASSOo9x3jqnSeYqRjiIs3KsQshQOsheL71r7PAKix2YHv5C6Buf8pqOApmHOxc1lXD1S cC4kvd8/cBL4qU9y/85W5N33/wMwTNgCf78o1hNiDkAiOjkaaKMznbC5yN/R0Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fg63D5bPnzdY for ; Tue, 24 Mar 2026 10:39:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 34508 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 24 Mar 2026 10:39:04 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 127aa056fea0 - main - sound: Retire CHN_SETVOLUME() and use chn_setvolume_matrix() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 127aa056fea0714116952efb7664956e0f2b69cd Auto-Submitted: auto-generated Date: Tue, 24 Mar 2026 10:39:04 +0000 Message-Id: <69c269c8.34508.21ac81d3@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=127aa056fea0714116952efb7664956e0f2b69cd commit 127aa056fea0714116952efb7664956e0f2b69cd Author: Christos Margiolis AuthorDate: 2026-03-24 10:32:04 +0000 Commit: Christos Margiolis CommitDate: 2026-03-24 10:38:41 +0000 sound: Retire CHN_SETVOLUME() and use chn_setvolume_matrix() CHN_SETVOLUME() is just a wrapped around chn_setvolume_matrix() anyway, so use it directly. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55992 --- sys/dev/sound/pcm/channel.c | 4 ++-- sys/dev/sound/pcm/channel.h | 2 -- sys/dev/sound/pcm/matrix.h | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/sys/dev/sound/pcm/channel.c b/sys/dev/sound/pcm/channel.c index 5e7c5772af01..67bbfba28177 100644 --- a/sys/dev/sound/pcm/channel.c +++ b/sys/dev/sound/pcm/channel.c @@ -143,7 +143,7 @@ chn_vpc_proc(int reset, int db) PCM_ACQUIRE(d); CHN_FOREACH(c, d, channels.pcm) { CHN_LOCK(c); - CHN_SETVOLUME(c, SND_VOL_C_PCM, SND_CHN_T_VOL_0DB, db); + chn_setvolume_matrix(c, SND_VOL_C_PCM, SND_CHN_T_VOL_0DB, db); if (reset != 0) chn_vpc_reset(c, SND_VOL_C_PCM, 1); CHN_UNLOCK(c); @@ -1635,7 +1635,7 @@ chn_vpc_reset(struct pcm_channel *c, int vc, int force) return; for (i = SND_CHN_T_BEGIN; i <= SND_CHN_T_END; i += SND_CHN_T_STEP) - CHN_SETVOLUME(c, vc, i, c->volume[vc][SND_CHN_T_VOL_0DB]); + chn_setvolume_matrix(c, vc, i, c->volume[vc][SND_CHN_T_VOL_0DB]); } static u_int32_t diff --git a/sys/dev/sound/pcm/channel.h b/sys/dev/sound/pcm/channel.h index 22c2bf5a4d3e..0375bbfb006d 100644 --- a/sys/dev/sound/pcm/channel.h +++ b/sys/dev/sound/pcm/channel.h @@ -306,8 +306,6 @@ int chn_notify(struct pcm_channel *c, u_int32_t flags); int chn_getrates(struct pcm_channel *c, int **rates); int chn_syncdestroy(struct pcm_channel *c); -#define CHN_SETVOLUME(...) chn_setvolume_matrix(__VA_ARGS__) - #define CHN_GETMUTE(x, y, z) ((x)->muted[y][z]) #ifdef OSSV4_EXPERIMENT diff --git a/sys/dev/sound/pcm/matrix.h b/sys/dev/sound/pcm/matrix.h index f4a79fdc3b30..ffac162f41a1 100644 --- a/sys/dev/sound/pcm/matrix.h +++ b/sys/dev/sound/pcm/matrix.h @@ -176,8 +176,7 @@ /* * Multichannel interleaved volume matrix. Each calculated value relative * to master and 0db will be stored in each CLASS + 1 as long as - * chn_setvolume_matrix() or the equivalent CHN_SETVOLUME() macros is - * used (see channel.c). + * chn_setvolume_matrix() is used (see channel.c). */ #define SND_VOL_C_MASTER 0 #define SND_VOL_C_PCM 1